firmware/controllers/algo/engine_cylinder.cpp
| Line | Branch | Decision | Exec | Source |
|---|---|---|---|---|
| 1 | /* | |||
| 2 | * @file engine_cylinder.cpp | |||
| 3 | * | |||
| 4 | * @date: may 25, 2025 | |||
| 5 | * @author Matthew Kennedy, FDSoftware | |||
| 6 | */ | |||
| 7 | #include "pch.h" | |||
| 8 | #include "engine_cylinder.hpp" | |||
| 9 | ||||
| 10 | 5736 | void OneCylinder::updateCylinderNumber(uint8_t index, uint8_t cylinderNumber) { | ||
| 11 | 5736 | m_cylinderIndex = index; | ||
| 12 | 5736 | m_cylinderNumber = cylinderNumber; | ||
| 13 | ||||
| 14 | // base = position of this cylinder in the firing order. | |||
| 15 | // We get a cylinder every n-th of an engine cycle where N is the number of cylinders | |||
| 16 | 5736 | m_baseAngleOffset = engine->engineState.engineCycle * index / engineConfiguration->cylindersCount; | ||
| 17 | ||||
| 18 | 5736 | m_valid = true; | ||
| 19 | 5736 | } | ||
| 20 | ||||
| 21 | 12540 | void OneCylinder::invalidCylinder() { | ||
| 22 | 12540 | m_valid = false; | ||
| 23 | 12540 | } | ||
| 24 | ||||
| 25 | 352908 | angle_t OneCylinder::getAngleOffset() const { | ||
| 26 |
2/2✓ Branch 0 taken 1 time.
✓ Branch 1 taken 352907 times.
|
2/2✓ Decision 'true' taken 1 time.
✓ Decision 'false' taken 352907 times.
|
352908 | if (!m_valid) { |
| 27 | 1 | return 0; | ||
| 28 | } | |||
| 29 | ||||
| 30 | // Plus or minus any adjustment if this is an odd-fire engine | |||
| 31 | 352907 | auto adjustment = engineConfiguration->timing_offset_cylinder[m_cylinderNumber]; | ||
| 32 | ||||
| 33 | 352907 | auto result = m_baseAngleOffset + adjustment; | ||
| 34 | ||||
| 35 |
2/4✓ Branch 0 taken 352907 times.
✗ Branch 1 not taken.
✗ Branch 2 not taken.
✓ Branch 3 taken 352907 times.
|
352907 | assertAngleRange(result, "getAngleOffset", ObdCode::CUSTOM_ERR_CYL_ANGLE); | |
| 36 | ||||
| 37 | 352907 | return result; | ||
| 38 | } | |||
| 39 | ||||
| 40 | 1523 | void EngineCylinders::updateCylinders() { | ||
| 41 | // Update valid cylinders with their position in the firing order | |||
| 42 | 1523 | uint16_t cylinderUpdateMask = 0; | ||
| 43 |
2/2✓ Branch 0 taken 5736 times.
✓ Branch 1 taken 1523 times.
|
2/2✓ Decision 'true' taken 5736 times.
✓ Decision 'false' taken 1523 times.
|
7259 | for (size_t i = 0; i < engineConfiguration->cylindersCount; i++) { |
| 44 | 5736 | auto cylinderNumber = getCylinderNumberAtIndex(i); | ||
| 45 | ||||
| 46 | 5736 | engine->cylinders[cylinderNumber].updateCylinderNumber(i, cylinderNumber); | ||
| 47 | ||||
| 48 | 5736 | auto mask = 1 << cylinderNumber; | ||
| 49 | // Assert that this cylinder was not configured yet | |||
| 50 |
1/2✗ Branch 0 not taken.
✓ Branch 1 taken 5736 times.
|
5736 | efiAssertVoid(ObdCode::OBD_PCM_Processor_Fault, (cylinderUpdateMask & mask) == 0, "cylinder update err"); | |
| 51 | 5736 | cylinderUpdateMask |= mask; | ||
| 52 | } | |||
| 53 | ||||
| 54 | // Assert that all cylinders were configured | |||
| 55 | 1523 | uint16_t expectedMask = (1 << (engineConfiguration->cylindersCount)) - 1; | ||
| 56 |
1/2✗ Branch 0 not taken.
✓ Branch 1 taken 1523 times.
|
1523 | efiAssertVoid(ObdCode::OBD_PCM_Processor_Fault, cylinderUpdateMask == expectedMask, "cylinder update err"); | |
| 57 | ||||
| 58 | // Invalidate the remaining cylinders | |||
| 59 |
2/2✓ Branch 1 taken 12540 times.
✓ Branch 2 taken 1523 times.
|
2/2✓ Decision 'true' taken 12540 times.
✓ Decision 'false' taken 1523 times.
|
14063 | for (size_t i = engineConfiguration->cylindersCount; i < efi::size(engine->cylinders); i++) { |
| 60 | 12540 | engine->cylinders[i].invalidCylinder(); | ||
| 61 | } | |||
| 62 | } | |||
| 63 |