[Success Story] Sand drag Cherokee with 2JZ GTE VVTI #24

Your chance to introduce yourself and your vehicle
porelmundo
contributor
contributor
Posts: 87
Joined: Tue Apr 26, 2016 1:15 am

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by porelmundo »

Something else, the new firmware changes mess up my IAT CLT sensor calibrations. In this log have some realistic numbers because i move the cal for check the compensation.
Attachments
2016-07-24_19.35.16.msl
(180.78 KiB) Downloaded 711 times
User avatar
AndreyB
Site Admin
Posts: 14325
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by AndreyB »

settings are not being saved while engine is running. Some firmware changes reset configuration but not the recent ones.

Your injector lag is set to 1.9 is that indended?
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
porelmundo
contributor
contributor
Posts: 87
Joined: Tue Apr 26, 2016 1:15 am

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by porelmundo »

Nop dead time is set to .98

User avatar
AndreyB
Site Admin
Posts: 14325
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by AndreyB »

porelmundo wrote:Nop dead time is set to .98
Shows 1.9 on the formula tab. Dead time consists of constant dead time (0.98) and VBatt dead time correction (0.93@14 volts), 0.98+0.93=1.9

I guess I need to re-align fields on this dialog or maybe use better defaults? https://sourceforge.net/p/rusefi/tickets/306/
Attachments
screenshot2.png
screenshot2.png (69.41 KiB) Viewed 13136 times
screenshot.png
screenshot.png (116.77 KiB) Viewed 13136 times
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
porelmundo
contributor
contributor
Posts: 87
Joined: Tue Apr 26, 2016 1:15 am

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by porelmundo »

Dont know why you need to add the constant twice, if you are at 13.0V. let me study the formula and i let you know. What i understand that formula multiply the constant with the variable not sum, 1 + 1 is 2 but 1 * 1 is not 2. what you are missing is a quadratic formula where zero can't be 2. if my numbers are incorrect, what are the correct ones?
Attachments
Deadtime.png
Deadtime.png (39.48 KiB) Viewed 13131 times
User avatar
AndreyB
Site Admin
Posts: 14325
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by AndreyB »

You need to set the value in the corner to zero and it would be good.

I will probably rename the value in the corner to "base injector dead time" and rename the table to "extra injector dead time"

Looks like the value in the corner is simply not needed, it's mostly there for historical reasons before I've added the VBatt curve.
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
porelmundo
contributor
contributor
Posts: 87
Joined: Tue Apr 26, 2016 1:15 am

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by porelmundo »

Better to take it out, i dont see the point, there is some other systems that use a base DT at 13.2 volts but is for reference, and is just a copy of the table, that is why i set it up like that. Will try it tomorrow.
User avatar
AndreyB
Site Admin
Posts: 14325
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by AndreyB »

I guess I agree, no need for this over-complication here. Will completely remove it under https://sourceforge.net/p/rusefi/tickets/306/
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
porelmundo
contributor
contributor
Posts: 87
Joined: Tue Apr 26, 2016 1:15 am

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by porelmundo »

Problem with the fuel at idle is fix, now i can set up the idle.
need to check why after the math change, my CLT and IAT calibration go off.
User avatar
AndreyB
Site Admin
Posts: 14325
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by AndreyB »

porelmundo wrote: need to check why after the math change, my CLT and IAT calibration go off.
please write down how exactly you are changing CLT calibration. Is engine running? in the bottom of TS screen do you have red 'BURN" indicator at any point? Does it stay or disappear?

I need more information to work with. Your messages are really short and I have to guess a lot. I do not see what you are doing, I am pretty far - it's hard to troubleshoot with so little information.
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
porelmundo
contributor
contributor
Posts: 87
Joined: Tue Apr 26, 2016 1:15 am

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by porelmundo »

I got a Toyota CLT and a GM CLT as a IAT so before we do the fuel_mat change everything was working now temperatures are frizz, that all explanation i can give, not working, coolant is frizz at 8.5 and IAT 26.9. not moving no work. I do a test and get back to old firmware and everything get back to normal. Is all i can say .
User avatar
AndreyB
Site Admin
Posts: 14325
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by AndreyB »

porelmundo wrote:my CLT and IAT calibration go off.
I read this as "I am unable to save CLT settings in TunerStudio - I am setting some resistance/temperature values but the values are not persisted". Is that correct?

Is the issue with calibration settings not being saved or is the issue with CLT and IAT not actually working on the gauges while settings are displayed correctly?
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
User avatar
AndreyB
Site Admin
Posts: 14325
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by AndreyB »

OMG it was such a ridiculous fresh bug :( I am sorry and thank you for your patience.

It's fixed now, just need to wait for http://rusefi.com/build_server/ to get the new bundle.
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
porelmundo
contributor
contributor
Posts: 87
Joined: Tue Apr 26, 2016 1:15 am

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by porelmundo »

Looks like evrthing is working on parameters, need to tune a lot of things but because i been working on some cars for a big automotive event this weekend i will not tunne untill next week, in the mid time we need to start working sycronizing the engine so we can acomlish the secuential injection and that is the first step to make the VVTI work, things that will help you on some other projects (VANOS, VVTI, EVTEC, IVVL, etc.) i'm lefting you here a code so you can have and idea of the trigger, for those who are reading the 2JZ VVTI have a 36-2 on the crank and 3 equaly spaces tooth on the cam, where every other cycle of the engine one of the tooth alines with tooth 34. take a look.

//initial sync
if (!(synch & SYNC_SYNCED)) {
if ((!tooth_diff_this) || (!tooth_diff_last)
|| (!tooth_diff_last_1)) {

return(0); // only sync when there's enough data
}
// when unsynced we wait until we see a missing tooth and then another one
// and count the teeth in-between

if (!(synch & SYNC_SEMI)) { // just starting
temp1 = tooth_diff_last + (tooth_diff_last >> 1); // 1.5*
if (tooth_diff_this > temp1) {
tooth_no = 0;
synch |= SYNC_SEMI; // started sync sequence
}
trig2cnt = 0;
return(0);
} else { // started sequence, check possible sync points
tooth_no++;
if (num_cyl == 4) {
if (tooth_no == 34) {
if (trig2cnt == 1) {
tooth_no = 34;
goto TWOJZ_OK;
} else if (trig2cnt == 2) {
tooth_no = 0;
goto TWOJZ_OK;
} else {
synch &= ~SYNC_SEMI;
}
}
} else { /* 6, 8 and 12 cyl */
/* look for cam tooth in certain areas only and determine phase */
/* examine 8-14 and 21-29 */
if ((tooth_no == 0) || (tooth_no == 12) || (tooth_no == 24)) {
trig2cnt = 0;
} else if ((tooth_no == 10) && trig2cnt) {
goto TWOJZ_OK;
} else if ((tooth_no == 22) && trig2cnt) {
tooth_no = 56;
goto TWOJZ_OK;
} else if ((tooth_no == 34) && trig2cnt) {
goto TWOJZ_OK;

} else if (tooth_no > 35) {
/* didn't find the second missing, start again */
synch &= ~SYNC_SEMI;
}
}
return(0);
}
TWOJZ_OK:
outpc.status1 |= STATUS1_SYNCFULL;
trig2cnt = 0;
synch &= ~SYNC_SEMI;
synch &= ~SYNC_SEMI2;
synch |= SYNC_SYNCED;
} else {
// recheck for sync in normal running - _only_ crank
if ((tooth_no == 34) || (tooth_no == 68)) { // (one less)
temp1 = tooth_diff_last + (tooth_diff_last >> 1); // 1.5*
if (tooth_diff_this <= temp1) {
outpc.syncreason = 84;
ign_reset();
return(0);
}
if (tooth_no == 68) {
tooth_no = 0;
}
}

/* cam phase validation during cranking */
if ((outpc.engine & ENGINE_CRANK) || (flagbyte2 & flagbyte2_crank_ok)) {
if (num_cyl == 4) {

if ((tooth_no == 34) || (tooth_no == 0)) {
if ( ((tooth_no == 34) && (trig2cnt != 1))
|| ((tooth_no == 0) && (trig2cnt != 2)) ) {
outpc.syncreason = 85;
ign_reset();
return(0);
} else {
trig2cnt = 0;
}
}

} else { /* 6, 8 and 12 cyl */
if ((tooth_no == 0) || (tooth_no == 46) || (tooth_no == 24)) {
trig2cnt = 0;
} else if (((tooth_no == 56) && (!trig2cnt))
|| ((tooth_no == 34) && (!trig2cnt))) {
outpc.syncreason = 85;
ign_reset();
return(0);
}
}
}
porelmundo
contributor
contributor
Posts: 87
Joined: Tue Apr 26, 2016 1:15 am

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by porelmundo »

Any chance to look at the code for sync?
User avatar
AndreyB
Site Admin
Posts: 14325
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by AndreyB »

porelmundo wrote:Any chance to look at the code for sync?
Very little progress made on anything while my family was staying with me, once I am back from the Lemons race I am now I hope to make progress. Let's plan to run some first test next weekend.
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
ItaloManyak
Posts: 69
Joined: Sun Sep 08, 2013 2:33 pm

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by ItaloManyak »

Can i see you ECU board?
User avatar
AndreyB
Site Admin
Posts: 14325
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by AndreyB »

Rob, can you please try CAM sensor position reading logic? You would need to set 'cam input' to PC6. Position could still be reported with a 360 degrees offset - we need to figure out if in your case we need 'first half' or 'second half' logic for vtti.

http://rusefi.com/wiki/index.php?title=Manual:Software:VVT
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
User avatar
AndreyB
Site Admin
Posts: 14325
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Sand drag Cherokee with 2JZ GTE VVTI #24

Post by AndreyB »

More cool stuff at https://rusefi.com/forum/viewtopic.php?p=36435#p36435 (not sure if same car or different car just similar engine)

Can you do me another favor? Can you update to latest firmware/latest project to get new engine make/code/name fields, fill in something and upload your tune to https://rusefi.com/online/?

More about this at https://github.com/rusefi/rusefi/wiki/Online

At this point that would be first 6 cylinder tune, any running tune would be better than nothing.
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Post Reply