Software knock processing

It's all about the code!
Hmelik
Posts: 14
Joined: Sun Jan 16, 2022 5:07 pm

Re: Software knock processing

Post by Hmelik »

neongreen
Posts: 44
Joined: Fri Apr 10, 2020 12:17 pm

Re: Software knock processing

Post by neongreen »

I'd really like to use knock logic in my project, but I have Frankenso. I understand it's currently only on some boards (Proteus and hellen?). Is there a reason we can't activate the logic on other boards? I have no issue repinning the harness to put knock on ADC03.
1962 Ford Falcon 5.0L V8 / T5
User avatar
AndreyB
Site Admin
Posts: 14368
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Software knock processing

Post by AndreyB »

neongreen wrote:
Mon Apr 24, 2023 1:26 am
it's currently only on some boards (Proteus and hellen?)
Frankenso has totally different electronics for knock, the not-software but ASIC approach which did not work out for us.

This thread saying "Software knock" means "not ASIC like on Frankenso"
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
neongreen
Posts: 44
Joined: Fri Apr 10, 2020 12:17 pm

Re: Software knock processing

Post by neongreen »

AndreyB wrote:
Mon Apr 24, 2023 4:27 am
neongreen wrote:
Mon Apr 24, 2023 1:26 am
it's currently only on some boards (Proteus and hellen?)
Frankenso has totally different electronics for knock, the not-software but ASIC approach which did not work out for us.

This thread saying "Software knock" means "not ASIC like on Frankenso"
Understood, but what I'm asking is why can software knock not be used on Frankenso? It has an ADC03.

I also realize that the frankenso doesn't have a knock amp, which is why I copied the proteus amp and had it built as an add on board.

Image

There is no access to the software knock in the F407 Discovery firmware version. Could that be activated?
1962 Ford Falcon 5.0L V8 / T5
User avatar
AndreyB
Site Admin
Posts: 14368
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Software knock processing

Post by AndreyB »

Ohhh now I understand the ask.

It could be possible, it could be pretty small effort but I am very overloaded on software side I can really use help from other software people.

https://github.com/rusefi/rusefi/issues/5254

First like of progress https://github.com/rusefi/rusefi/commit/75d14a0cea44c4aa325dd61058353eb8e85946fe
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
neongreen
Posts: 44
Joined: Fri Apr 10, 2020 12:17 pm

Re: Software knock processing

Post by neongreen »

Thanks Andrey. I wish I were more help on software, but looking at the code I feel like a six year old attempting to figure out how an Airbus A320 works.
1962 Ford Falcon 5.0L V8 / T5
User avatar
AndreyB
Site Admin
Posts: 14368
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Software knock processing

Post by AndreyB »

vag0dr04er is teasing me so let me tease everyone else
WhatsApp Image 2024-03-23 at 06.08.18_348ef01d.jpg
WhatsApp Image 2024-03-23 at 06.08.18_348ef01d.jpg (347.64 KiB) Viewed 2928 times
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
User avatar
AndreyB
Site Admin
Posts: 14368
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Software knock processing

Post by AndreyB »

Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
tmbryhn
Posts: 170
Joined: Wed Feb 12, 2020 2:40 am
Location: Norway

Re: Software knock processing

Post by tmbryhn »

Great demo video 👍🏼

I've been playing around with knock in RusEFi for some time, and come across a limitation in flexibility that sets it apart from eg. MS3 that uses the dedicated TI knock DSP chip.

Particularly on setups that utilises one knock sensor, there's sometimes a non-trivial delta in peak noise level generated by the individual cylinders. On systems using a global knock threshold (like RusEFi and MS3), this can be problematic to fine tune unless a sound gain can be defined on a per-cylinder basis. MS3 has this feature as a part of the DSP stage which allows for a more or less equal amplitude between the different cylinders.

As I understand it, RusEFi operates with a fixed gain analog filter input feeding directly into the dedicated knock DSP ADC. To implement a variable gain feature; could instead the digital value generated by the ADC be scaled by a variable factor associated with each cylinder as a type of "software gain" feature?
User avatar
AndreyB
Site Admin
Posts: 14368
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Software knock processing

Post by AndreyB »

Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
User avatar
AndreyB
Site Admin
Posts: 14368
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Software knock processing

Post by AndreyB »

Alexey @vag0dr04er has contributed _something_ - right now it's available in Proteus firmware, let me see if I can also enable it for 4chan and uaefi

https://github.com/rusefi/rusefi/pull/6467
image.png
image.png (753.07 KiB) Viewed 1005 times
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Post Reply