Fw. improvement - PANIC BUTTON

It's all about the code!
Post Reply
JRD McLAREN
contributor
contributor
Posts: 193
Joined: Mon Mar 04, 2019 10:19 pm

Fw. improvement - PANIC BUTTON

Post by JRD McLAREN »

I have (another one stupid) idea to improve rusEFI FW ...

Some other standalone ECUs have something like "Panic Button" function.
It is "user triggered" button, for any reasons ...
User push the button when they feel / or hear when something is wrong ...

On HW side it is "grounding" one of the analog input.

On SW side ...
The "stupid ones" just highlight some parts on log file, and "we" can find any area on log file much easier.
- I'm not sure, if TS or MegalogViewer can serve this ...

The "smart one" has added value like:
- Boost Cut
- Ignition retard
- Fuel add
- Cut off engine
- etc.

What are you thinking about this ..??
User avatar
AndreyB
Site Admin
Posts: 11416
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Fw. improvement - PANIC BUTTON

Post by AndreyB »

Please start with an explanation of who and why would need that new button. What is the big picture here?
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239
puff
contributor
contributor
Posts: 2861
Joined: Mon Nov 11, 2013 11:28 am
Location: Moskau

Re: Fw. improvement - PANIC BUTTON

Post by puff »

This could be a handy tool to make timestamps of interest in the logfiles... This would probably make the further analysis of logs a bit easier.
User avatar
AndreyB
Site Admin
Posts: 11416
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Fw. improvement - PANIC BUTTON

Post by AndreyB »

puff wrote:
Tue Feb 23, 2021 8:23 pm
This could be a handy tool to make timestamps of interest in the logfiles... This would probably make the further analysis of logs a bit easier.
:( So far this is "let's have a magic button which reads user's mind and does exactly what users wants! more power! less power! log timestamps!"
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239
JRD McLAREN
contributor
contributor
Posts: 193
Joined: Mon Mar 04, 2019 10:19 pm

Re: Fw. improvement - PANIC BUTTON

Post by JRD McLAREN »

AndreyB please calm down. I'm not your enemy ..

PUFF explain a basic function of this button.
(when you hear misfire, hear knocking, feel lazy engine rev up - due to lean/rich mixture, etc.)

I can see or hear the opinion of other people.

For brainstorming:
every ecu with one free analog input, has this "basic function" ...
but it call something different ...
blundar
contributor
contributor
Posts: 100
Joined: Tue Jan 07, 2014 4:38 am
Location: Cincinnati, Ohio
Github Username: blundar
Slack: Dave B.
Contact:

Re: Fw. improvement - PANIC BUTTON

Post by blundar »

The way I read this, there are two somewhat independent requests.

1. Hit button - get log event. This is a pretty common feature in a lot of software I use. The idea is a very sound one. Particularly in long datalogs, it's often hard to pick out the moment(s) of greatest interest. If you have a button activated by the user that creates an "entry of interest" on the log, then that can make all the difference in identifying juicy moments. This conceivably could be implemented by tagging a analog channel that is logged as "Interesting Analog" and wiring it with a pull {up,down} to change its state. You can use the changed state of "Interesting Analog" to find juicy log bits.

2. Hit button - Panic/shutdown. This is not a terribly common feature on street cars but is commonly accessible on race cars in the form of some button that shuts off power to _____. I think this feature could be implemented in ECU logic but I question the value keeping the ECU active while shutting down boost/fuel/ign/etc. would have. I think that some form of "valet mode" where power was limited by a function of DBW/rev limit/boost limit/etc. could almost be adapted to a "panic button" because the reduced "valet" parameters would probably also suit "panic" mode.
User avatar
AndreyB
Site Admin
Posts: 11416
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: Fw. improvement - PANIC BUTTON

Post by AndreyB »

blundar wrote:
Tue Feb 23, 2021 9:17 pm
The way I read this, there are two somewhat independent requests.
Thank you! It's fundamentally easier to understand once things are not piled together.

https://en.wikipedia.org/wiki/Divide-and-conquer_algorithm is a fundamental concept.
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239
User avatar
kb1gtt
contributor
contributor
Posts: 3715
Joined: Tue Sep 10, 2013 1:42 am
Location: ME of USA

Re: Fw. improvement - PANIC BUTTON

Post by kb1gtt »

blundar wrote:
Tue Feb 23, 2021 9:17 pm
2. Hit button - Panic/shutdown.
Something like this is required on monster trucks that are preforming a show. The kill switch is controlled by any one of three people. If the driver gets knocked out any one of the staff members can press the button and kill the engine before the truck makes it to the crowd. The kill switch requires a constant radio signal to allow the engine to work.
Welcome to the friendlier side of internet crazy :)
mck1117
running engine in first post
running engine in first post
Posts: 880
Joined: Mon Jan 30, 2017 2:05 am
Location: Seattle-ish

Re: Fw. improvement - PANIC BUTTON

Post by mck1117 »

it sounds like there are actually two asks here that are getting confused:
  1. kill switch: "please stop injecting fuel now"
  2. limp home switch: "please limit power output and do something safe so I can pull over"
User avatar
kb1gtt
contributor
contributor
Posts: 3715
Joined: Tue Sep 10, 2013 1:42 am
Location: ME of USA

Re: Fw. improvement - PANIC BUTTON

Post by kb1gtt »

I think there is a third inquiry / request. A push button to highlight stuff in the log.
Welcome to the friendlier side of internet crazy :)
JRD McLAREN
contributor
contributor
Posts: 193
Joined: Mon Mar 04, 2019 10:19 pm

Re: Fw. improvement - PANIC BUTTON

Post by JRD McLAREN »

1. - Timestamp in LOG file, or any other mark in LOG file, and no other action is needed ...
2. - Safety function, ign. retard, boost cut .. etc ...
3. - Kill switch .. stop engine immediately

???

We have first one ...
blundar wrote:1. Hit button - get log event. This is a pretty common feature in a lot of software I use. The idea is a very sound one. Particularly in long datalogs, it's often hard to pick out the moment(s) of greatest interest. If you have a button activated by the user that creates an "entry of interest" on the log, then that can make all the difference in identifying juicy moments. This conceivably could be implemented by tagging a analog channel that is logged as "Interesting Analog" and wiring it with a pull {up,down} to change its state. You can use the changed state of "Interesting Analog" to find juicy log bits.
First and second can be the same button ...
Third "KILL SWITCH" separate .. ??
deaner
Posts: 56
Joined: Sat Jan 09, 2021 2:02 am

Re: Fw. improvement - PANIC BUTTON

Post by deaner »

I reckon mental resources would be better suited to building better failsafes via corrections or limp mode. The ECU will find fault and shut things down far faster than a person can compute that theres a problem and manually hit a button. I used to like gauges and warning lights in my cars. Nowadays, I let the ecu figure all that out after setting failsafes lol. Ive seen the ecu catch stretched timing chains, bad tanks of fuel, failing timing belt tensioner and failing injectors and wastegates...things a person would never be able to catch and react to in time. Just my .02.
JRD McLAREN
contributor
contributor
Posts: 193
Joined: Mon Mar 04, 2019 10:19 pm

Re: Fw. improvement - PANIC BUTTON

Post by JRD McLAREN »

Computers doing thing faster in every conditions... that's true ...
but not better in every condition or right way ...

(they need any kind of sensors .. but what they do, when sensors fail ..?? )
(or wires, pipes, hoses etc.)

The first requirement for "good automated safety function" are good maps / and all other data.
You must create maps and collect this (right) data.

This type of button may help you "find this data" ..
OrchardPerformance
contributor
contributor
Posts: 290
Joined: Tue Jul 24, 2018 8:55 pm

Re: Fw. improvement - PANIC BUTTON

Post by OrchardPerformance »

I think within the plan for "smart features" the concept of a panic trigger could be included.
A single flag based on a pin state that manually triggers "limp mode" (what ever that may turn out to be or the user chooses it to be).

It might actually be worth including that as part of a test mode for limp, same as we have for other feature test buttons. My understanding there would be that it only needs to set the same flag as the limp triggers when a pinstate is high/low to work.

I will try to incorporate this into the logic for the smart features as I can see the utility, there have been times I have seen something odd but not been able to mark the log in any way to indicate when exactly it was.
Now keeping MRE and Proteus in stock in the UK, PM or slack for details.
dexter_lab
Posts: 27
Joined: Sun Feb 02, 2020 8:01 pm

Re: Fw. improvement - PANIC BUTTON

Post by dexter_lab »

it will be great if the logging is made on "sliding window" for example 10sec and when you press the button to record those 10sec
OrchardPerformance
contributor
contributor
Posts: 290
Joined: Tue Jul 24, 2018 8:55 pm

Re: Fw. improvement - PANIC BUTTON

Post by OrchardPerformance »

I don't think that is possible, that would be tunerstudio side and probably not something we could implement.
Now keeping MRE and Proteus in stock in the UK, PM or slack for details.
Post Reply