MRE and EGT option

It's all about the code!
Post Reply
JRD McLAREN
contributor
contributor
Posts: 368
Joined: Mon Mar 04, 2019 10:19 pm
Location: Slovakia

MRE and EGT option

Post by JRD McLAREN »

Is able make EGT option "visible" in any future release ..?

due to: https://rusefi.com/forum/viewtopic.php?p=43270#p43270
Attachments
Screenshot_20211121_101205.png
Screenshot_20211121_101205.png (91.4 KiB) Viewed 4206 times
.. some Proteus and microRusEFI for sale in Europe ..
User avatar
AndreyB
Site Admin
Posts: 12795
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: MRE and EGT option

Post by AndreyB »

Done
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
JRD McLAREN
contributor
contributor
Posts: 368
Joined: Mon Mar 04, 2019 10:19 pm
Location: Slovakia

Re: MRE and EGT option

Post by JRD McLAREN »

Well 8-)

still waiting for Godot ...

Thanks.
.. some Proteus and microRusEFI for sale in Europe ..
JRD McLAREN
contributor
contributor
Posts: 368
Joined: Mon Mar 04, 2019 10:19 pm
Location: Slovakia

Re: MRE and EGT option

Post by JRD McLAREN »

I still can't see EGT option in TS ... :?
(stable 20211114)
.. some Proteus and microRusEFI for sale in Europe ..
User avatar
AndreyB
Site Admin
Posts: 12795
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: MRE and EGT option

Post by AndreyB »

What is the relation between "Sun Nov 21" done and 2021-11-14 version?
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
JRD McLAREN
contributor
contributor
Posts: 368
Joined: Mon Mar 04, 2019 10:19 pm
Location: Slovakia

Re: MRE and EGT option

Post by JRD McLAREN »

SORRY ....

I'm an idiot ... ...
.. some Proteus and microRusEFI for sale in Europe ..
User avatar
AndreyB
Site Admin
Posts: 12795
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: MRE and EGT option

Post by AndreyB »

JRD McLAREN wrote:
Thu Jan 06, 2022 6:57 pm
SORRY ....
You are in best company here!
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
JRD McLAREN
contributor
contributor
Posts: 368
Joined: Mon Mar 04, 2019 10:19 pm
Location: Slovakia

Re: MRE and EGT option

Post by JRD McLAREN »

..it is thereee..... and IT WORKS ...
Attachments
mre_egt.png
mre_egt.png (155.11 KiB) Viewed 3858 times
.. some Proteus and microRusEFI for sale in Europe ..
JRD McLAREN
contributor
contributor
Posts: 368
Joined: Mon Mar 04, 2019 10:19 pm
Location: Slovakia

Re: MRE and EGT option

Post by JRD McLAREN »

I'm got this error ....
chsys.err.png
chsys.err.png (57.37 KiB) Viewed 3172 times
it occur when EGT chip SPI & CS pin are selected,
no sensor connected (to MAX31855)

and MRE is conected, or to be connected to TS (via USB or BT)
MRE drop to FATAL, and engine STOP ...

(it is not too safe, when you overtake and something cut EGT senror wire)
.. some Proteus and microRusEFI for sale in Europe ..
klpaul
Posts: 5
Joined: Mon May 24, 2021 9:07 am

Re: MRE and EGT option

Post by klpaul »

JRD McLAREN wrote:
Thu Jan 06, 2022 7:47 pm
..it is thereee..... and IT WORKS ...
What version of MRE firmware are you using for EGT to work? I connected MAX31855 to SPI3(PC10, PC11, PC12) and СS(PA 15) and EGT doesn't work.
I am using stm32f405 discovery. If you write the firmware from Frankenso, then the EGT works.
Attachments
2022-03-30_075723.jpg
2022-03-30_075723.jpg (264.02 KiB) Viewed 2028 times
JRD McLAREN
contributor
contributor
Posts: 368
Joined: Mon Mar 04, 2019 10:19 pm
Location: Slovakia

Re: MRE and EGT option

Post by JRD McLAREN »

this is for microRusEFI ... not for others ... :roll:
.. some Proteus and microRusEFI for sale in Europe ..
mck1117
running engine in first post
running engine in first post
Posts: 1268
Joined: Mon Jan 30, 2017 2:05 am
Location: Seattle-ish

Re: MRE and EGT option

Post by mck1117 »

klpaul wrote:
Wed Mar 30, 2022 4:59 am
JRD McLAREN wrote:
Thu Jan 06, 2022 7:47 pm
..it is thereee..... and IT WORKS ...
What version of MRE firmware are you using for EGT to work? I connected MAX31855 to SPI3(PC10, PC11, PC12) and СS(PA 15) and EGT doesn't work.
I am using stm32f405 discovery. If you write the firmware from Frankenso, then the EGT works.
We disabled it on MRE 🙃 edit: looks like I was even the one who broke it, oops

Will be fixed soon: https://github.com/rusefi/rusefi/pull/4026
image.png
image.png (38.86 KiB) Viewed 2023 times
JRD McLAREN
contributor
contributor
Posts: 368
Joined: Mon Mar 04, 2019 10:19 pm
Location: Slovakia

Re: MRE and EGT option

Post by JRD McLAREN »

..in latest firmware ... ??? :o
.. some Proteus and microRusEFI for sale in Europe ..
mck1117
running engine in first post
running engine in first post
Posts: 1268
Joined: Mon Jan 30, 2017 2:05 am
Location: Seattle-ish

Re: MRE and EGT option

Post by mck1117 »

That linked pull request will merge some time tomorrow morning (8-12 hours from now), then it will be in the latest snapshot firmware.
JRD McLAREN
contributor
contributor
Posts: 368
Joined: Mon Mar 04, 2019 10:19 pm
Location: Slovakia

Re: MRE and EGT option

Post by JRD McLAREN »

I have 20220126 .. and it have EGT option ..

EDITED: but I can't test it at this moment ...
.. some Proteus and microRusEFI for sale in Europe ..
mck1117
running engine in first post
running engine in first post
Posts: 1268
Joined: Mon Jan 30, 2017 2:05 am
Location: Seattle-ish

Re: MRE and EGT option

Post by mck1117 »

JRD McLAREN wrote:
Wed Mar 30, 2022 7:16 am
I have 20220126 .. and it have EGT option ..

EDITED: but I can't test it at this moment ...
Correct, you do have it on 2022 01 26. It was broken after that.
klpaul
Posts: 5
Joined: Mon May 24, 2021 9:07 am

Re: MRE and EGT option

Post by klpaul »

mck1117 wrote:
Wed Mar 30, 2022 6:42 am
klpaul wrote:
Wed Mar 30, 2022 4:59 am
JRD McLAREN wrote:
Thu Jan 06, 2022 7:47 pm
..it is thereee..... and IT WORKS ...
What version of MRE firmware are you using for EGT to work? I connected MAX31855 to SPI3(PC10, PC11, PC12) and СS(PA 15) and EGT doesn't work.
I am using stm32f405 discovery. If you write the firmware from Frankenso, then the EGT works.
We disabled it on MRE 🙃 edit: looks like I was even the one who broke it, oops

Will be fixed soon: https://github.com/rusefi/rusefi/pull/4026

image.png
Thank's mck1117, EGT work.
On one SPI, egt and sd card do not work, either egt or sd card. Can you add the ability to disable flash memory on SPI2 in the TS menu so that you can connect a SD card to SPI2?
The SD card will be on SPI2, and on SPI3 there will be EGT.
Attachments
2022-03-30_194742.jpg
2022-03-30_194742.jpg (185.97 KiB) Viewed 1990 times
User avatar
AndreyB
Site Admin
Posts: 12795
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: MRE and EGT option

Post by AndreyB »

klpaul wrote:
Wed Mar 30, 2022 6:06 pm
Can you add the ability to disable flash memory
rusEFI does not use flash memory at all there is nothing to disable.
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
klpaul
Posts: 5
Joined: Mon May 24, 2021 9:07 am

Re: MRE and EGT option

Post by klpaul »

AndreyB wrote:
Wed Mar 30, 2022 6:11 pm
klpaul wrote:
Wed Mar 30, 2022 6:06 pm
Can you add the ability to disable flash memory
rusEFI does not use flash memory at all there is nothing to disable.
Can you Enable SPI2 on MRE in TS? because it doesn't work.
User avatar
AndreyB
Site Admin
Posts: 12795
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: MRE and EGT option

Post by AndreyB »

klpaul wrote:
Wed Mar 30, 2022 11:06 pm
Can you Enable SPI2 on MRE in TS? because it doesn't work.
please upload your tune to rusEFI online
please provide a URL of the exact dialog where you are failing to make a change

"doesn't work." is vague please use more of technical terms
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
klpaul
Posts: 5
Joined: Mon May 24, 2021 9:07 am

Re: MRE and EGT option

Post by klpaul »

AndreyB wrote:
Wed Mar 30, 2022 11:16 pm
klpaul wrote:
Wed Mar 30, 2022 11:06 pm
Can you Enable SPI2 on MRE in TS? because it doesn't work.
please upload your tune to rusEFI online
please provide a URL of the exact dialog where you are failing to make a change

"doesn't work." is vague please use more of technical terms
SPI_1=true //for TLE8888
SPI_3=true //for SD, EGT and other
SPI_2 none
I want SD card and EGT to work. Because EGT and SD CARD don't work at the same time on SPI3.
board_configuration file

Code: Select all

...........
static void setupTle8888() {
	// on microRusEFI SPI3 is exposed on PC10/PC11 and there is interest to use SD card there
	// PB3/PB4 could be either SPI1 or SP3, let's use not SPI3 to address the contention
	// Enable spi1
	engineConfiguration->is_enabled_spi_1 = true;

	// Wire up spi1
	engineConfiguration->spi1mosiPin = GPIOB_5;
	engineConfiguration->spi1misoPin = GPIOB_4;
	engineConfiguration->spi1sckPin = GPIOB_3;

	// Chip select
	engineConfiguration->tle8888_cs = GPIOD_5;

	// SPI device
	engineConfiguration->tle8888spiDevice = SPI_DEVICE_1;
}
.............
void setBoardConfigOverrides() {
	setLedPins();
	setupVbatt();
	setupTle8888();
	setupEtb();

	engineConfiguration->clt.config.bias_resistor = 2700;
	engineConfiguration->iat.config.bias_resistor = 2700;

	engineConfiguration->canTxPin = GPIOB_6;
	engineConfiguration->canRxPin = GPIOB_12;

	// SPI for SD card
	engineConfiguration->is_enabled_spi_3 = true;
	engineConfiguration->sdCardSpiDevice = SPI_DEVICE_3;

	engineConfiguration->spi3mosiPin = GPIOC_12;
	engineConfiguration->spi3misoPin = GPIOC_11;
	engineConfiguration->spi3sckPin = GPIOC_10;
}
User avatar
AndreyB
Site Admin
Posts: 12795
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: MRE and EGT option

Post by AndreyB »

Sorry do not follow, you've jumped from TS to board file I was not able to follow what leads to what
klpaul wrote:
Thu Mar 31, 2022 12:36 am
Because EGT and SD CARD don't work at the same time on SPI3.
why? maybe proper route is to fix this defect in the code?
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
mck1117
running engine in first post
running engine in first post
Posts: 1268
Joined: Mon Jan 30, 2017 2:05 am
Location: Seattle-ish

Re: MRE and EGT option

Post by mck1117 »

AndreyB wrote:
Thu Mar 31, 2022 12:41 am
why? maybe proper route is to fix this defect in the code?
btw we made the explicit choice to not support multiple devices per bus to avoid any priority inversion due to locking of the shared resource
klpaul
Posts: 5
Joined: Mon May 24, 2021 9:07 am

Re: MRE and EGT option

Post by klpaul »

AndreyB wrote:
Thu Mar 31, 2022 12:41 am
Sorry do not follow, you've jumped from TS to board file I was not able to follow what leads to what
klpaul wrote:
Thu Mar 31, 2022 12:36 am
Because EGT and SD CARD don't work at the same time on SPI3.
why? maybe proper route is to fix this defect in the code?
Okay Andrey, please fix it.

Why is flash memory needed on the MPE board?
Attachments
2022-03-31_034455.jpg
2022-03-31_034455.jpg (39.43 KiB) Viewed 1895 times
JRD McLAREN
contributor
contributor
Posts: 368
Joined: Mon Mar 04, 2019 10:19 pm
Location: Slovakia

Re: MRE and EGT option

Post by JRD McLAREN »

Flash memory is not used ..
mck1117 wrote:
Thu Mar 31, 2022 12:42 am
AndreyB wrote:
Thu Mar 31, 2022 12:41 am
why? maybe proper route is to fix this defect in the code?
btw we made the explicit choice to not support multiple devices per bus to avoid any priority inversion due to locking of the shared resource
When I'm testing my addon borad, EGT and SDcard woks together on SPI3 bus .. ..
Attachments
Screenshot_20220331_103611.png
Screenshot_20220331_103611.png (12.31 KiB) Viewed 1782 times
.. some Proteus and microRusEFI for sale in Europe ..
Post Reply