ETB with single TPS input - 2016+ GM/Daewoo

It's all about the code!
MadGoatCustoms
Posts: 31
Joined: Thu Feb 24, 2022 12:47 pm

Re: ETB with single TPS input - 2016+ GM/Daewoo

Post by MadGoatCustoms »

It works. The engine is running on SENT TPS.
One suggestion, remove the other pin options from the dropdown for SENT input. Why would you give the user an option if there's only one pin that can possibly work?
User avatar
AndreyB
Site Admin
Posts: 14292
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: ETB with single TPS input - 2016+ GM/Daewoo

Post by AndreyB »

Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
User avatar
Dron_Gus
contributor
contributor
Posts: 451
Joined: Wed Nov 13, 2013 1:11 pm
Location: S-Pb
Github Username: dron0gus

Re: ETB with single TPS input - 2016+ GM/Daewoo

Post by Dron_Gus »

MadGoatCustoms wrote:
Tue Mar 07, 2023 7:48 pm
Why would you give the user an option if there's only one pin that can possibly work?
Because you are the first real user of SENT! Congratulations! And thank you for testing!
tmbryhn
Posts: 169
Joined: Wed Feb 12, 2020 2:40 am
Location: Norway

Re: ETB with single TPS input - 2016+ GM/Daewoo

Post by tmbryhn »

I got a 12675730AA throttle body on the bench planned to be fitted to a new engine project running Discovery_F407 FW on some custom hardware.
I just discovered it has what appears to be SENT TPS instead of regular dual analog output. I opened the gearbox cover and scoped the output; clean 5V square waves.

Would it be possible to have SENT implemented on other builds than MRE?
User avatar
AndreyB
Site Admin
Posts: 14292
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: ETB with single TPS input - 2016+ GM/Daewoo

Post by AndreyB »

tmbryhn wrote:
Thu Jul 06, 2023 12:15 am
Would it be possible to have SENT implemented on other builds than MRE?
Sure let's try that on discovery firmware https://github.com/rusefi/rusefi/commit/e457d3f543070a726d332571bd79998e904ec9f9
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
tmbryhn
Posts: 169
Joined: Wed Feb 12, 2020 2:40 am
Location: Norway

Re: ETB with single TPS input - 2016+ GM/Daewoo

Post by tmbryhn »

Thanks. Just downloaded nightly built discovery (updated 5 hours ago), but can't find SENT settings in TPS menu.
Is it updated yet?
User avatar
AndreyB
Site Admin
Posts: 14292
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: ETB with single TPS input - 2016+ GM/Daewoo

Post by AndreyB »

Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
tmbryhn
Posts: 169
Joined: Wed Feb 12, 2020 2:40 am
Location: Norway

Re: ETB with single TPS input - 2016+ GM/Daewoo

Post by tmbryhn »

Finally got to test SENT on custom hardware running latest release candidate of Discovery_F407.

I've removed Capacitor on RC filter asscosiated with analog input goint to PC4 pin for a clean square wave signal.
If I configure the TPS as a regular analog input, I can see the jitter from the SENT square wave signal coming in on the analog chanel.

I proceed to disable analog inputs, and define TPS input as shown in attached photo. I get "No ICU" error upon burning changes.
Screenshot_20230730_143121_com.android.gallery3d.jpg
Screenshot_20230730_143121_com.android.gallery3d.jpg (523.76 KiB) Viewed 5795 times
Is there a problem with using arbitrary pins on the MCU for SENT input that deviates from what's standard in the MRE build?
User avatar
AndreyB
Site Admin
Posts: 14292
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: ETB with single TPS input - 2016+ GM/Daewoo

Post by AndreyB »

Current implementation requires ICU which stands for "input capture unit" which allows for precision timing capture. No support for arbitrary pins not sure if that's even possible.

So you have to use one of the (few) pins with ICU.
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
tmbryhn
Posts: 169
Joined: Wed Feb 12, 2020 2:40 am
Location: Norway

Re: ETB with single TPS input - 2016+ GM/Daewoo

Post by tmbryhn »

Understood. I'll switch over to one of my analog temp inputs connected to PA1 and remove RC filter capacitor on that channel 👍🏼
Thank you for swift response! 🙏🏼
tmbryhn
Posts: 169
Joined: Wed Feb 12, 2020 2:40 am
Location: Norway

Re: ETB with single TPS input - 2016+ GM/Daewoo

Post by tmbryhn »

Tested yesterday. SENT w. GM-TB works like a charm on Discovery_F407 when signal is routed to MCU pin PA1 :D
Post Reply