Firmware developent status

It's all about the code!
stefanst
contributor
contributor
Posts: 587
Joined: Wed Feb 17, 2016 12:24 am

Re: Firmware developent status

Post by stefanst »

Anything <=0 should be an error.
And log(x) == x should never be true for any number x.

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

2017-04-02 01_10: EngineState: FATAL error: Natural logarithm logf() is broken: 18000.00
2017-04-02 01_10: EngineState: FATAL error: Natural logarithm logf() is broken: 18000.00
2017-04-02 01_10: EngineState: FATAL error: Natural logarithm logf() is broken: 18000.00
2017-04-02 01_10: EngineState: FATAL error: Natural logarithm logf() is broken: 18000.00
2017-04-02 01_10: EngineState: FATAL error: Natural logarithm logf() is broken: 18000.00
log(18000.0)==18000.0

:(
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

mobyfab wrote:You're using softfp in the Makefile, so it's not fully used.
It has to copy register data from regular to FP registers everytime you need FP.
Looks like this natural logarithm issue is caused by switching from softfp to hard. We are not doing something right I guess, rolling that change back for now.

See https://github.com/rusefi/rusefi/issues/375
See original ticket from a while back https://sourceforge.net/p/rusefi/tickets/149/
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

ChibiOS3 migration is pretty much done, looking for help with last step: anyone to start a real vehicle using http://rusefi.com/temp/test_chibios_3.zip ? Download/uncompress/flash and publish some log file if car runs fine?

My test mule is waiting for new alternator. Looks like alternators do not like to be excited while output wire is not hooked up.
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

Firmware help needed: https://github.com/rusefi/rusefi/issues/382

that's an effort to migrate from three separate log entry namings in three different places to using the same constants everywhere by means of wider code generation. All the tools are ready, the remaining part is to actually go locate all the names and extract into the common file.
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

Major change: @ has migrated rusEfi to ChibiOS 3.1
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

new issue - "integration with TunerStudio: 3.0.20 and 3.0.21 something is broken" - 3.0.20 and 3.0.21 are pretty unuseable with rusEfi. I am emailing EFI Analytics
https://github.com/rusefi/rusefi/issues/403

Latest known good version http://tunerstudio.com/downloads2/Tuner ... 3.0.18.exe
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

https://github.com/rusefi/rusefi/issues/403 closed - TS 3.0.22 fixes the issue
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

Yet another defect reported by @ fixed - https://github.com/rusefi/rusefi/issues/404
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

TunerStudio 3.0.22 knows rusEFI signature now - in a couple of weeks I will switch from older test signature into proper signature, this would mean everyone would need to migrate to 3.0.22 or newer to use rusEfi with TunerStudio.

Usability progress - version is now displayed in TunerStudio title.
Attachments
screenshot.png
screenshot.png (33.99 KiB) Viewed 6290 times
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

Abricos
contributor
contributor
Posts: 752
Joined: Mon Aug 18, 2014 12:32 am

Re: Firmware developent status

Post by Abricos »

Small jump congratulations ...

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

https://github.com/rusefi/rusefi/issues/429 is an incompatible protocol change - you would have to use latest console or TS project with latest firmware.
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

@ has discovered a bug in PID implementation - https://github.com/rusefi/rusefi/issues/435

It's about minValue/maxValue handing which is currently implemented by artifically setting iTerm to a funny value, even while iFactor is zero, which value then stays forever?!

https://github.com/rusefi/rusefi/blob/m ... th/pid.cpp
/**
* If we have exceeded the ability of the controlled device to hit target, the I factor will keep accumulating and approach infinity.
* Here we limit the I-term #353
*/
if (iTerm > pid->maxValue - (pTerm + dTerm + pid->offset))
iTerm = pid->maxValue - (pTerm + dTerm + pid->offset);

if (iTerm < pid->minValue - (pTerm + dTerm + pid->offset))
iTerm = pid->minValue - (pTerm + dTerm + pid->offset);

and here is a unit test which shows wrong behaviour:

Code: Select all

	pidS.pFactor = 1;
	pidS.iFactor = 0;
	pidS.dFactor = 0;
	pidS.offset = 0;
	pidS.minValue = 0;
	pidS.maxValue = 100;
	pidS.period = 1;

	pid.reset();

	assertEqualsM("target=50, input=0", 50, pid.getValue(/*target*/50, /*input*/0));
	assertEqualsM("target=50, input=0 iTerm", 0, pid.iTerm);

	assertEqualsM("target=50, input=70", 0, pid.getValue(/*target*/50, /*input*/70));
	assertEqualsM("target=50, input=70 iTerm", 20, pid.iTerm);

	assertEqualsM("target=50, input=70 #2", 0, pid.getValue(/*target*/50, /*input*/70));
	// WOW, we are getting non-zero iTerm while iFactor is zero?!
	assertEqualsM("target=50, input=70 iTerm #2", 20, pid.iTerm);

	// and now we inherit this iTerm even for cases where targer==input?! NOT RIGHT
	assertEqualsM("target=50, input=50", 20, pid.getValue(/*target*/50, /*input*/50));
	assertEqualsM("target=50, input=50 iTerm", 20, pid.iTerm);
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

Finally Lamborghini Diablo firing order https://github.com/rusefi/rusefi/commit ... bb7a191102
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

puff
contributor
contributor
Posts: 2770
Joined: Mon Nov 11, 2013 11:28 am
Location: Moskau

Re: Firmware developent status

Post by puff »

It's not April's fool, is it? :D

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

I wanted to add mass storage drivers into the firmware for a while but I though that I've lost the working sample. I've found it!

Would anyone with a MAC try the sample firmware from ARMCM4-STM32F407-DISCOVERY-USB-MASS-STORAGE-SPI.zip from https://github.com/rusefi/rusefi/issues/140? That's without rusEfi but using rusEfi default SD card pinout.
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

For first step my idea is two use the user button to switch between USB port modes: normal mode serial USB, is reset while holding button it would be mass storage instead.

Theoretically a composite device could be possible but that's above my current USB skills.
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

I did not realize that TS supports text fields!
Attachments
screenshot.png
screenshot.png (83.37 KiB) Viewed 5769 times
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
Dron_Gus
donator
donator
Posts: 179
Joined: Wed Nov 13, 2013 1:11 pm
Location: S-Pb

Re: Firmware developent status

Post by Dron_Gus »

russian wrote:For first step my idea is two use the user button to switch between USB port modes: normal mode serial USB, is reset while holding button it would be mass storage instead.

Theoretically a composite device could be possible but that's above my current USB skills.
I can try implementing composite device. CDC + MSD.

User avatar
mobyfab
Posts: 139
Joined: Tue Oct 29, 2013 10:09 am
Location: Versailles, France
Soldering skill: yes
Coding skill?: yes

Re: Firmware developent status

Post by mobyfab »

Dron_Gus wrote:
russian wrote:For first step my idea is two use the user button to switch between USB port modes: normal mode serial USB, is reset while holding button it would be mass storage instead.

Theoretically a composite device could be possible but that's above my current USB skills.
I can try implementing composite device. CDC + MSD.
This might help: https://github.com/fpoussin/MotoLink/bl ... b_config.c

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

Another week of vacation :)
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

A lot of life in the way of firmware progress these days.
Attachments
max.JPG
max.JPG (1.08 MiB) Viewed 5229 times
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

puff
contributor
contributor
Posts: 2770
Joined: Mon Nov 11, 2013 11:28 am
Location: Moskau

Re: Firmware developent status

Post by puff »

!!! congrats!!!
your first kid?

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

Thank you :)
It's complicated :)
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
kb1gtt
contributor
contributor
Posts: 3564
Joined: Tue Sep 10, 2013 1:42 am
Location: ME of USA
Contact:

Re: Firmware developent status

Post by kb1gtt »

Such a cute little one. Assuming that's yours and not a rental, your going to have allot less time in the near future.
Welcome to the friendlier side of internet crazy :)

matt
donator
donator
Posts: 271
Joined: Fri Aug 26, 2016 11:32 am
Location: malaysia

Re: Firmware developent status

Post by matt »

Congratulations!!

User avatar
mobyfab
Posts: 139
Joined: Tue Oct 29, 2013 10:09 am
Location: Versailles, France
Soldering skill: yes
Coding skill?: yes

Re: Firmware developent status

Post by mobyfab »

Congrats!!

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

Making an incompatible configuration change today - https://github.com/rusefi/rusefi/issues/495
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

While I am not making too much progress these days, @ and @ are really pushing cold start and idle control forward!
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

User avatar
AndreyB
Site Admin
Posts: 10034
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Soldering skill: yes
Coding skill?: yes
Contact:

Re: Firmware developent status

Post by AndreyB »

Just migrated to latest stable ChibiOS - see https://github.com/rusefi/rusefi/issues/463

minor issue with it - need to fix https://github.com/rusefi/rusefi/issues/551 but that should be easy
https://rusefi.com/s/howtocontribute
very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
my skype is arro239

Post Reply