36-4 trigger wheel

It's all about the code!
Post Reply
PhilTheGeek
Posts: 11
Joined: Sun Oct 11, 2015 4:14 pm

36-4 trigger wheel

Post by PhilTheGeek »

I'm trying to implement support for a Rover K series 36-4 trigger pattern. This is 13-1-2-1-14-1-3-1 where the 1's are missing teeth. There's no camshaft sensor so this needs to sync on the crank alone. Code as it stands is below. It works without the two commented lines but isn't sync'd so TDC can be anywhere. If I uncomment then I get the orange LED flashing and "line:52:msg,FATAL error: totalRevolutionCounter2 expected 3" repeated in the console. Am I going to be able to sort this without adding a camshaft sensor?

Code: Select all

void configureKMpiTriggerShape(TriggerShape *s DECLARE_ENGINE_PARAMETER_S) 
{
  s->initialize(FOUR_STROKE_CRANK_SENSOR, false);

  float tooth = 20;

//  s->setTriggerSynchronizationGap(2.0);
//  s->isSynchronizationNeeded = true;

  float base = 0;

  for (int i = 0; i < 2; i++) 
  {
      s->addEvent(base + tooth / 2, T_PRIMARY, TV_RISE);
      s->addEvent(base + tooth, T_PRIMARY, TV_FALL);
      base += tooth;
  }
  base += tooth;
  for (int i = 0; i < 2; i++) {
      s->addEvent(base + tooth / 2, T_PRIMARY, TV_RISE);
      s->addEvent(base + tooth, T_PRIMARY, TV_FALL);
      base += tooth;
  }
  base += tooth;
  for (int i = 0; i < 14; i++) {
      s->addEvent(base + tooth / 2, T_PRIMARY, TV_RISE);
      s->addEvent(base + tooth, T_PRIMARY, TV_FALL);
      base += tooth;
  }
  base += tooth;
  for (int i = 0; i < 3; i++) {
      s->addEvent(base + tooth / 2, T_PRIMARY, TV_RISE);
      s->addEvent(base + tooth, T_PRIMARY, TV_FALL);
      base += tooth;
  }
  base += tooth;
  for (int i = 0; i < 11; i++) {
      s->addEvent(base + tooth / 2, T_PRIMARY, TV_RISE);
      s->addEvent(base + tooth, T_PRIMARY, TV_FALL);
      base += tooth;
  }
}
User avatar
AndreyB
Site Admin
Posts: 14332
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: 36-4 trigger wheel

Post by AndreyB »

PhilTheGeek wrote:"line:52:msg,FATAL error: totalRevolutionCounter2 expected 3"
I will now change this message to be more helpful: what is happening here is your 'gap' ratio is not 2 so synchronization validation fails.

I usually run unit_tests.exe with additional logging to see what are the actual gaps, you can try setting

Code: Select all

engineConfiguration->isPrintTriggerSynchDetails = true;
or add a breakpoint where it does gap calculation in trigger_decoder.

I will now figure this out for you, adding trigger_rover.cpp file as we speak.
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
User avatar
AndreyB
Site Admin
Posts: 14332
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: 36-4 trigger wheel

Post by AndreyB »

Code: Select all

addEvent 700.000000
addEvent 710.000000
addEvent 720.000000
TT_ROVER_K event SHAFT_PRIMARY_UP 10000
current gap nan/nan c=0 prev=0
TT_ROVER_K isSynchronizationPoint=0 index=0 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 20000
TT_ROVER_K event SHAFT_PRIMARY_UP 30000
current gap inf/nan c=20000 prev=0
TT_ROVER_K isSynchronizationPoint=0 index=2 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 40000
TT_ROVER_K event SHAFT_PRIMARY_UP 70000
current gap 2.000000/inf c=40000 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=4 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 80000
TT_ROVER_K event SHAFT_PRIMARY_UP 90000
current gap 0.500000/2.000000 c=20000 prev=40000
TT_ROVER_K isSynchronizationPoint=0 index=6 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 100000
TT_ROVER_K event SHAFT_PRIMARY_UP 129999
current gap 1.999950/0.500000 c=39999 prev=20000
TT_ROVER_K isSynchronizationPoint=1 index=8 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 140000
TT_ROVER_K event SHAFT_PRIMARY_UP 149999
current gap 0.500013/1.999950 c=20000 prev=39999
TT_ROVER_K isSynchronizationPoint=0 index=1 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 160000
TT_ROVER_K event SHAFT_PRIMARY_UP 169999
current gap 1.000000/0.500013 c=20000 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=3 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 180000
TT_ROVER_K event SHAFT_PRIMARY_UP 190000
current gap 1.000050/1.000000 c=20001 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=5 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 200000
TT_ROVER_K event SHAFT_PRIMARY_UP 209999
current gap 0.999900/1.000050 c=19999 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=7 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 219999
TT_ROVER_K event SHAFT_PRIMARY_UP 230000
current gap 1.000100/0.999900 c=20001 prev=19999
TT_ROVER_K isSynchronizationPoint=0 index=9 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 240000
TT_ROVER_K event SHAFT_PRIMARY_UP 249999
current gap 0.999900/1.000100 c=19999 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=11 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 259999
TT_ROVER_K event SHAFT_PRIMARY_UP 270000
current gap 1.000100/0.999900 c=20001 prev=19999
TT_ROVER_K isSynchronizationPoint=0 index=13 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 280000
TT_ROVER_K event SHAFT_PRIMARY_UP 290000
current gap 0.999950/1.000100 c=20000 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=15 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 299999
TT_ROVER_K event SHAFT_PRIMARY_UP 309999
current gap 0.999950/0.999950 c=19999 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=17 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 320000
TT_ROVER_K event SHAFT_PRIMARY_UP 330000
current gap 1.000100/0.999950 c=20001 prev=19999
TT_ROVER_K isSynchronizationPoint=0 index=19 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 339999
TT_ROVER_K event SHAFT_PRIMARY_UP 349999
current gap 0.999900/1.000100 c=19999 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=21 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 360000
TT_ROVER_K event SHAFT_PRIMARY_UP 370000
current gap 1.000100/0.999900 c=20001 prev=19999
TT_ROVER_K isSynchronizationPoint=0 index=23 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 380000
TT_ROVER_K event SHAFT_PRIMARY_UP 390000
current gap 0.999950/1.000100 c=20000 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=25 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 400000
TT_ROVER_K event SHAFT_PRIMARY_UP 429999
current gap 1.999950/0.999950 c=39999 prev=20000
TT_ROVER_K isSynchronizationPoint=1 index=27 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 439999
TT_ROVER_K event SHAFT_PRIMARY_UP 450000
current gap 0.500037/1.999950 c=20001 prev=39999
TT_ROVER_K isSynchronizationPoint=0 index=1 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 460000
TT_ROVER_K event SHAFT_PRIMARY_UP 470000
current gap 0.999950/0.500037 c=20000 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=3 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 480000
TT_ROVER_K event SHAFT_PRIMARY_UP 509999
current gap 1.999950/0.999950 c=39999 prev=20000
TT_ROVER_K isSynchronizationPoint=1 index=5 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 519999
TT_ROVER_K event SHAFT_PRIMARY_UP 529999
current gap 0.500013/1.999950 c=20000 prev=39999
TT_ROVER_K isSynchronizationPoint=0 index=1 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 540000
TT_ROVER_K event SHAFT_PRIMARY_UP 550000
current gap 1.000050/0.500013 c=20001 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=3 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 560000
TT_ROVER_K event SHAFT_PRIMARY_UP 570000
current gap 0.999950/1.000050 c=20000 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=5 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 580000
TT_ROVER_K event SHAFT_PRIMARY_UP 589999
current gap 0.999950/0.999950 c=19999 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=7 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 599999
TT_ROVER_K event SHAFT_PRIMARY_UP 609999
current gap 1.000050/0.999950 c=20000 prev=19999
TT_ROVER_K isSynchronizationPoint=0 index=9 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 619999
TT_ROVER_K event SHAFT_PRIMARY_UP 630000
current gap 1.000050/1.000050 c=20001 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=11 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 640000
TT_ROVER_K event SHAFT_PRIMARY_UP 650000
current gap 0.999950/1.000050 c=20000 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=13 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 660000
TT_ROVER_K event SHAFT_PRIMARY_UP 670000
current gap 1.000000/0.999950 c=20000 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=15 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 679999
TT_ROVER_K event SHAFT_PRIMARY_UP 689999
current gap 0.999950/1.000000 c=19999 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=17 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 699999
TT_ROVER_K event SHAFT_PRIMARY_UP 709999
current gap 1.000050/0.999950 c=20000 prev=19999
TT_ROVER_K isSynchronizationPoint=0 index=19 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 720000
TT_ROVER_K event SHAFT_PRIMARY_UP 730000
current gap 1.000050/1.000050 c=20001 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=21 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 740000
TT_ROVER_K event SHAFT_PRIMARY_UP 750000
current gap 0.999950/1.000050 c=20000 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=23 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 760000
TT_ROVER_K event SHAFT_PRIMARY_UP 790000
current gap 2.000000/0.999950 c=40000 prev=20000
TT_ROVER_K isSynchronizationPoint=1 index=25 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 800000
TT_ROVER_K event SHAFT_PRIMARY_UP 810000
current gap 0.500000/2.000000 c=20000 prev=40000
TT_ROVER_K isSynchronizationPoint=0 index=1 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 820000
TT_ROVER_K event SHAFT_PRIMARY_UP 849999
current gap 1.999950/0.500000 c=39999 prev=20000
TT_ROVER_K isSynchronizationPoint=1 index=3 SHAFT_PRIMARY_UP
Warning: trigger decoding issue. expected %d/%d/%d got %d/%d/%d
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 860000
TT_ROVER_K event SHAFT_PRIMARY_UP 869999
current gap 0.500013/1.999950 c=20000 prev=39999
TT_ROVER_K isSynchronizationPoint=0 index=1 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 880000
TT_ROVER_K event SHAFT_PRIMARY_UP 889999
current gap 1.000000/0.500013 c=20000 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=3 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 900000
TT_ROVER_K event SHAFT_PRIMARY_UP 910000
current gap 1.000050/1.000000 c=20001 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=5 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 920000
TT_ROVER_K event SHAFT_PRIMARY_UP 929999
current gap 0.999900/1.000050 c=19999 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=7 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 939999
TT_ROVER_K event SHAFT_PRIMARY_UP 950000
current gap 1.000100/0.999900 c=20001 prev=19999
TT_ROVER_K isSynchronizationPoint=0 index=9 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 960000
TT_ROVER_K event SHAFT_PRIMARY_UP 969999
current gap 0.999900/1.000100 c=19999 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=11 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 979999
TT_ROVER_K event SHAFT_PRIMARY_UP 990000
current gap 1.000100/0.999900 c=20001 prev=19999
TT_ROVER_K isSynchronizationPoint=0 index=13 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1000000
TT_ROVER_K event SHAFT_PRIMARY_UP 1010000
current gap 0.999950/1.000100 c=20000 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=15 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1019999
TT_ROVER_K event SHAFT_PRIMARY_UP 1029999
current gap 0.999950/0.999950 c=19999 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=17 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1040000
TT_ROVER_K event SHAFT_PRIMARY_UP 1050000
current gap 1.000100/0.999950 c=20001 prev=19999
TT_ROVER_K isSynchronizationPoint=0 index=19 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1059999
TT_ROVER_K event SHAFT_PRIMARY_UP 1069999
current gap 0.999900/1.000100 c=19999 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=21 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1080000
TT_ROVER_K event SHAFT_PRIMARY_UP 1090000
current gap 1.000100/0.999900 c=20001 prev=19999
TT_ROVER_K isSynchronizationPoint=0 index=23 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1100000
TT_ROVER_K event SHAFT_PRIMARY_UP 1110000
current gap 0.999950/1.000100 c=20000 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=25 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1120000
TT_ROVER_K event SHAFT_PRIMARY_UP 1149999
current gap 1.999950/0.999950 c=39999 prev=20000
TT_ROVER_K isSynchronizationPoint=1 index=27 SHAFT_PRIMARY_UP
Warning: trigger decoding issue. expected %d/%d/%d got %d/%d/%d
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1159999
TT_ROVER_K event SHAFT_PRIMARY_UP 1170000
current gap 0.500037/1.999950 c=20001 prev=39999
TT_ROVER_K isSynchronizationPoint=0 index=1 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1180000
TT_ROVER_K event SHAFT_PRIMARY_UP 1190000
current gap 0.999950/0.500037 c=20000 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=3 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1200000
TT_ROVER_K event SHAFT_PRIMARY_UP 1229999
current gap 1.999950/0.999950 c=39999 prev=20000
TT_ROVER_K isSynchronizationPoint=1 index=5 SHAFT_PRIMARY_UP
Warning: trigger decoding issue. expected %d/%d/%d got %d/%d/%d
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1239999
TT_ROVER_K event SHAFT_PRIMARY_UP 1249999
current gap 0.500013/1.999950 c=20000 prev=39999
TT_ROVER_K isSynchronizationPoint=0 index=1 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1260000
TT_ROVER_K event SHAFT_PRIMARY_UP 1270000
current gap 1.000050/0.500013 c=20001 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=3 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1280000
TT_ROVER_K event SHAFT_PRIMARY_UP 1290000
current gap 0.999950/1.000050 c=20000 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=5 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1300000
TT_ROVER_K event SHAFT_PRIMARY_UP 1309999
current gap 0.999950/0.999950 c=19999 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=7 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1319999
TT_ROVER_K event SHAFT_PRIMARY_UP 1329999
current gap 1.000050/0.999950 c=20000 prev=19999
TT_ROVER_K isSynchronizationPoint=0 index=9 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1339999
TT_ROVER_K event SHAFT_PRIMARY_UP 1350000
current gap 1.000050/1.000050 c=20001 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=11 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1360000
TT_ROVER_K event SHAFT_PRIMARY_UP 1370000
current gap 0.999950/1.000050 c=20000 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=13 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1380000
TT_ROVER_K event SHAFT_PRIMARY_UP 1390000
current gap 1.000000/0.999950 c=20000 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=15 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1399999
TT_ROVER_K event SHAFT_PRIMARY_UP 1409999
current gap 0.999950/1.000000 c=19999 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=17 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1419999
TT_ROVER_K event SHAFT_PRIMARY_UP 1429999
current gap 1.000050/0.999950 c=20000 prev=19999
TT_ROVER_K isSynchronizationPoint=0 index=19 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1440000
TT_ROVER_K event SHAFT_PRIMARY_UP 1450000
current gap 1.000050/1.000050 c=20001 prev=20000
TT_ROVER_K isSynchronizationPoint=0 index=21 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1460000
TT_ROVER_K event SHAFT_PRIMARY_UP 1470000
current gap 0.999950/1.000050 c=20000 prev=20001
TT_ROVER_K isSynchronizationPoint=0 index=23 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1480000
TT_ROVER_K event SHAFT_PRIMARY_UP 1510000
current gap 2.000000/0.999950 c=40000 prev=20000
TT_ROVER_K isSynchronizationPoint=1 index=25 SHAFT_PRIMARY_UP
Warning: trigger decoding issue. expected %d/%d/%d got %d/%d/%d
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1520000
TT_ROVER_K event SHAFT_PRIMARY_UP 1530000
current gap 0.500000/2.000000 c=20000 prev=40000
TT_ROVER_K isSynchronizationPoint=0 index=1 SHAFT_PRIMARY_UP
TT_ROVER_K isLessImportant SHAFT_PRIMARY_DOWN 1540000
TT_ROVER_K event SHAFT_PRIMARY_UP 1569999
current gap 1.999950/0.500000 c=39999 prev=20000
TT_ROVER_K isSynchronizationPoint=1 index=3 SHAFT_PRIMARY_UP
Warning: trigger decoding issue. expected %d/%d/%d got %d/%d/%d
totalRevolutionCounter2 expected 3
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
User avatar
AndreyB
Site Admin
Posts: 14332
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: 36-4 trigger wheel

Post by AndreyB »

grep current
current gap nan/nan c=0 prev=0
current gap inf/nan c=20000 prev=0
current gap 2.000000/inf c=40000 prev=20000
current gap 0.500000/2.000000 c=20000 prev=40000
current gap 1.999950/0.500000 c=39999 prev=20000
current gap 0.500013/1.999950 c=20000 prev=39999
current gap 1.000000/0.500013 c=20000 prev=20000
current gap 1.000050/1.000000 c=20001 prev=20000
current gap 0.999900/1.000050 c=19999 prev=20001
current gap 1.000100/0.999900 c=20001 prev=19999
current gap 0.999900/1.000100 c=19999 prev=20001
current gap 1.000100/0.999900 c=20001 prev=19999
current gap 0.999950/1.000100 c=20000 prev=20001
current gap 0.999950/0.999950 c=19999 prev=20000
current gap 1.000100/0.999950 c=20001 prev=19999
current gap 0.999900/1.000100 c=19999 prev=20001
current gap 1.000100/0.999900 c=20001 prev=19999
current gap 0.999950/1.000100 c=20000 prev=20001
current gap 1.999950/0.999950 c=39999 prev=20000
current gap 0.500037/1.999950 c=20001 prev=39999
current gap 0.999950/0.500037 c=20000 prev=20001
current gap 1.999950/0.999950 c=39999 prev=20000
current gap 0.500013/1.999950 c=20000 prev=39999
current gap 1.000050/0.500013 c=20001 prev=20000
current gap 0.999950/1.000050 c=20000 prev=20001
current gap 0.999950/0.999950 c=19999 prev=20000
current gap 1.000050/0.999950 c=20000 prev=19999
current gap 1.000050/1.000050 c=20001 prev=20000
current gap 0.999950/1.000050 c=20000 prev=20001
current gap 1.000000/0.999950 c=20000 prev=20000
current gap 0.999950/1.000000 c=19999 prev=20000
current gap 1.000050/0.999950 c=20000 prev=19999
current gap 1.000050/1.000050 c=20001 prev=20000
current gap 0.999950/1.000050 c=20000 prev=20001
current gap 2.000000/0.999950 c=40000 prev=20000
current gap 0.500000/2.000000 c=20000 prev=40000
current gap 1.999950/0.500000 c=39999 prev=20000
current gap 0.500013/1.999950 c=20000 prev=39999
current gap 1.000000/0.500013 c=20000 prev=20000
current gap 1.000050/1.000000 c=20001 prev=20000
current gap 0.999900/1.000050 c=19999 prev=20001
current gap 1.000100/0.999900 c=20001 prev=19999
current gap 0.999900/1.000100 c=19999 prev=20001
current gap 1.000100/0.999900 c=20001 prev=19999
current gap 0.999950/1.000100 c=20000 prev=20001
current gap 0.999950/0.999950 c=19999 prev=20000
current gap 1.000100/0.999950 c=20001 prev=19999
current gap 0.999900/1.000100 c=19999 prev=20001
current gap 1.000100/0.999900 c=20001 prev=19999
current gap 0.999950/1.000100 c=20000 prev=20001
current gap 1.999950/0.999950 c=39999 prev=20000
current gap 0.500037/1.999950 c=20001 prev=39999
current gap 0.999950/0.500037 c=20000 prev=20001
current gap 1.999950/0.999950 c=39999 prev=20000
current gap 0.500013/1.999950 c=20000 prev=39999
current gap 1.000050/0.500013 c=20001 prev=20000
current gap 0.999950/1.000050 c=20000 prev=20001
current gap 0.999950/0.999950 c=19999 prev=20000
current gap 1.000050/0.999950 c=20000 prev=19999
current gap 1.000050/1.000050 c=20001 prev=20000
current gap 0.999950/1.000050 c=20000 prev=20001
current gap 1.000000/0.999950 c=20000 prev=20000
current gap 0.999950/1.000000 c=19999 prev=20000
current gap 1.000050/0.999950 c=20000 prev=19999
current gap 1.000050/1.000050 c=20001 prev=20000
current gap 0.999950/1.000050 c=20000 prev=20001
current gap 2.000000/0.999950 c=40000 prev=20000
current gap 0.500000/2.000000 c=20000 prev=40000
current gap 1.999950/0.500000 c=39999 prev=20000
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
User avatar
AndreyB
Site Admin
Posts: 14332
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: 36-4 trigger wheel

Post by AndreyB »

Ops, my current algorithm is not capable of synchronizing such a trigger wheel :(
Image

Since you are saying there is no cam sensor it sounds like I would need to improve my trigger decode.
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
User avatar
AndreyB
Site Admin
Posts: 14332
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: 36-4 trigger wheel

Post by AndreyB »

Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
PhilTheGeek
Posts: 11
Joined: Sun Oct 11, 2015 4:14 pm

Re: 36-4 trigger wheel

Post by PhilTheGeek »

Excellent, that seems to work well on the bare discovery board.

Can I suggest a couple more files are modified?
TunerStudio ini file:
Line 135:
Change from:
trigger_type = bits, U32, 536, [0:4], "custom toothed wheel", "ford aspire", "dodge neon", "Miata NA", "Miata NB", "GM_7X", "Cooper", "Mazda SOHC 4", "60/2", "36/1", "Accord CD", "MITSU", "ACCORD 2", "ACCORD DIP", "Neon 2003", "MAZDA D 1+4", "1+1", "1+60/2", "Single Tooth", "Dodge Ram 1+16", "60/2 VW", "Accord 1+24", "DODGE STRATUS", "36_2_2_2", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID"
to:
trigger_type = bits, U32, 536, [0:4], "custom toothed wheel", "ford aspire", "dodge neon", "Miata NA", "Miata NB", "GM_7X", "Cooper", "Mazda SOHC 4", "60/2", "36/1", "Accord CD", "MITSU", "ACCORD 2", "ACCORD DIP", "Neon 2003", "MAZDA D 1+4", "1+1", "1+60/2", "Single Tooth", "Dodge Ram 1+16", "60/2 VW", "Accord 1+24", "DODGE STRATUS", "36_2_2_2", "Nissan", "2JZ", "Rover K", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID"

Console fields.java:
Line 79:
Change from:
public static final String[] trigger_type_e = {"custom toothed wheel", "ford aspire", "dodge neon", "Miata NA", "Miata NB", "GM_7X", "Cooper", "Mazda SOHC 4", "60/2", "36/1", "Accord CD", "MITSU", "ACCORD 2", "ACCORD DIP", "Neon 2003", "MAZDA D 1+4", "1+1", "1+60/2", "Single Tooth", "Dodge Ram 1+16", "60/2 VW", "Accord 1+24", "DODGE STRATUS", "36_2_2_2", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID"};

To:
public static final String[] trigger_type_e = {"custom toothed wheel", "ford aspire", "dodge neon", "Miata NA", "Miata NB", "GM_7X", "Cooper", "Mazda SOHC 4", "60/2", "36/1", "Accord CD", "MITSU", "ACCORD 2", "ACCORD DIP", "Neon 2003", "MAZDA D 1+4", "1+1", "1+60/2", "Single Tooth", "Dodge Ram 1+16", "60/2 VW", "Accord 1+24", "DODGE STRATUS", "36_2_2_2", "Nissan", "2JZ", "Rover K", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID"};

And lastly, I've read the contributor agreement and it's fine by me. Do you want a signed copy?
User avatar
AndreyB
Site Admin
Posts: 14332
Joined: Wed Aug 28, 2013 1:28 am
Location: Jersey City
Github Username: rusefillc
Slack: Andrey B

Re: 36-4 trigger wheel

Post by AndreyB »

Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions

Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
KLAS
Posts: 23
Joined: Tue Jul 14, 2015 8:58 am

Re: 36-4 trigger wheel

Post by KLAS »

seems i lost all good reasons why i didn't made any progress with my Rover K engine .... ;)
Post Reply