default_ignition.cpp File Reference

Functions
static void	setDefaultMultisparkParameters ()
static void	setDefaultIatTimingCorrection ()
static void	setDefaultCltTimingCorrection ()
static void	setDefaultTrailingSparkTable ()
static float	getAdvanceForRpm (float rpm, float advanceMax)
float	getInitialAdvance (float rpm, float map, float advanceMax)
static void	buildTimingMap (float advanceMax)
void	setDefaultIgnition ()

Function Documentation

buildTimingMap()

static void buildTimingMap ( float  advanceMax )

static

this method builds a good-enough base timing advance map bases on a number of heuristics

good enough (but do not trust us!) default timing map in case of MAP-based engine load

Definition at line 87 of file default_ignition.cpp.

                                             {
    if (engineConfiguration->fuelAlgorithm != engine_load_mode_e::LM_SPEED_DENSITY) {
        warning(ObdCode::CUSTOM_WRONG_ALGORITHM, "wrong algorithm for MAP-based timing");
        return;
    }
    /**
     * good enough (but do not trust us!) default timing map in case of MAP-based engine load
     */
    for (int loadIndex = 0; loadIndex < IGN_LOAD_COUNT; loadIndex++) {
        float load = config->ignitionLoadBins[loadIndex];
        for (int rpmIndex = 0;rpmIndex<IGN_RPM_COUNT;rpmIndex++) {
            float rpm = config->ignitionRpmBins[rpmIndex];
            config->ignitionTable[loadIndex][rpmIndex] = getInitialAdvance(rpm, load, advanceMax);
        }
    }
}

Referenced by setDefaultIgnition().

Here is the call graph for this function:

Here is the caller graph for this function:

getAdvanceForRpm()

static float getAdvanceForRpm ( float  rpm, float  advanceMax  )

static

Definition at line 61 of file default_ignition.cpp.

                                                           {
    if (rpm >= 3000) {
        return advanceMax;
    }
 
    if (rpm < 600) {
        return 10;
    }
 
    return interpolateMsg("advance", 600, 10, 3000, advanceMax, rpm);
}

Referenced by getInitialAdvance().

Here is the call graph for this function:

Here is the caller graph for this function:

getInitialAdvance()

float getInitialAdvance	(	float	rpm,
		float	map,
		float	advanceMax
	)

this method is used to build default advance map

Definition at line 75 of file default_ignition.cpp.

                                                                {
    map = std::min(map, 100.0f);
    float advance = getAdvanceForRpm(rpm, advanceMax);
 
    if (rpm >= 3000)
        return round10(advance + 0.1 * (100 - map));
    return round10(advance + 0.1 * (100 - map) * rpm / 3000);
}

Referenced by buildTimingMap().

Here is the call graph for this function:

Here is the caller graph for this function:

setDefaultCltTimingCorrection()

static void setDefaultCltTimingCorrection ( )

static

Definition at line 37 of file default_ignition.cpp.

                                            {
    setLinearCurve(config->ignitionCltCorrLoadBins, /*from=*/ 0, /*to*/ 140, 1);
  setLinearCurve(config->ignitionCltCorrTempBins, -20, 60, 1);
 
#if CLT_TIMING_CURVE_SIZE == 5
    for (size_t i = 0; i < CLT_TIMING_CURVE_SIZE; i++) {
      // huh? use setArrayValues? and we probably get all zeros by default anyway?
        copyArray(config->ignitionCltCorrTable[i], {0.0, 0.0, 0.0, 0.0, 0.0});
    }
#endif
}

Referenced by setDefaultIgnition().

Here is the call graph for this function:

Here is the caller graph for this function:

setDefaultIatTimingCorrection()

static void setDefaultIatTimingCorrection ( )

static

Definition at line 18 of file default_ignition.cpp.

                                            {
    setLinearCurve(config->ignitionIatCorrLoadBins, /*from=*/ 0, /*to*/ 140, 1);
#if IAT_IGN_CORR_COUNT == 8
    copyArray(config->ignitionIatCorrTempBins, { -40, 0, 10, 20, 30, 40, 50, 60});
 
    // top 5 rows are the same
    for (size_t i = 3; i < IAT_IGN_CORR_COUNT; i++) {
        //                                                         40  50  60 deg C
        copyArray(config->ignitionIatCorrTable[i], {0.0, 0.0, 0.0, 0.0, 0.0, -1.0, -2.0, -3.0});
    }
 
    // 6th row tapers out
    //                                                        40  50  60 deg C
    copyArray(config->ignitionIatCorrTable[2], {0.0, 0.0, 0.0, 0.0, 0.0, 0.0, -1.0, -2.0});
#else
  setLinearCurve(config->ignitionIatCorrTempBins, /*from=*/ -40, /*to*/ 60, 1);
#endif
}

Referenced by setDefaultIgnition().

Here is the call graph for this function:

Here is the caller graph for this function:

setDefaultIgnition()

void setDefaultIgnition

(

)

Definition at line 104 of file default_ignition.cpp.

                          {
    // Ignition base settings
    engineConfiguration->isIgnitionEnabled = true;
 
    engineConfiguration->timingMode = TM_DYNAMIC;
    engineConfiguration->fixedModeTiming = 50;
 
    engineConfiguration->minimumIgnitionTiming = -10;
    engineConfiguration->maximumIgnitionTiming = 60;
 
    // Dwell table - a bit conservative but reasonable
    setConstantDwell(4);
 
    setLinearCurve(config->dwellVoltageCorrVoltBins, 8, 15, 0.1);
    setLinearCurve(config->dwellVoltageCorrValues, 1, 1, 1);
 
    // Multispark
    setDefaultMultisparkParameters();
 
    // Ignition advance table
    setLinearCurve(config->ignitionLoadBins, 20, 120, 3);
    setTimingRpmBin(800, 7000);
    buildTimingMap(35);
 
    setDefaultTrailingSparkTable();
 
    // CLT correction
    setDefaultCltTimingCorrection();
 
    // IAT correction
    setDefaultIatTimingCorrection();
 
    // Give default axes for cylinder trim tables
#if IGN_TRIM_SIZE == 4
    copyArray(config->ignTrimRpmBins, { 1000, 3000, 5000, 7000 });
    copyArray(config->ignTrimLoadBins, { 20, 50, 80, 100 });
#else
  setRpmTableBin(config->ignTrimRpmBins);
  setLinearCurve(config->ignTrimLoadBins, 20, 100);
#endif
 
    // Default axes for VE blends
    for (size_t i = 0; i < efi::size(config->ignBlends); i++) {
        auto& blend = config->ignBlends[i];
        setLinearCurve(blend.loadBins, 0, 100, 10);
        setLinearCurve(blend.rpmBins, 0, 7000);
 
        setLinearCurve(blend.blendBins, 0, 100);
        setLinearCurve(blend.blendValues, 0, 100);
    }
}

Referenced by setDefaultEngineConfiguration().

Here is the call graph for this function:

Here is the caller graph for this function:

setDefaultMultisparkParameters()

static void setDefaultMultisparkParameters ( )

static

Definition at line 7 of file default_ignition.cpp.

                                             {
    // 1ms spark + 2ms dwell
    engineConfiguration->multisparkSparkDuration = 1;
    engineConfiguration->multisparkDwell = 2;
 
    // Conservative defaults - probably won't blow up coils
    engineConfiguration->multisparkMaxRpm = 1500;
    engineConfiguration->multisparkMaxExtraSparkCount = 2;
    engineConfiguration->multisparkMaxSparkingAngle = 30;
}

Referenced by setDefaultIgnition().

Here is the caller graph for this function:

setDefaultTrailingSparkTable()

static void setDefaultTrailingSparkTable ( )

static

Definition at line 49 of file default_ignition.cpp.

                                           {
    setLinearCurve(config->trailingSparkLoadBins, 20, 100, 1);
    setRpmTableBin(config->trailingSparkRpmBins);
 
#if TRAILING_SPARK_SIZE == 4
    for (size_t i = 0; i < TRAILING_SPARK_SIZE; i++) {
        copyArray(config->trailingSparkTable[i], {7,9,10,12});
    }
#endif
 
}

Referenced by setDefaultIgnition().

Here is the call graph for this function:

Here is the caller graph for this function:

Go to the source code of this file.