IgnitionState Class Reference

#include <ignition_state.h>

Inheritance diagram for IgnitionState:

Collaboration diagram for IgnitionState:

Public Member Functions
void	updateDwell (float rpm, bool isCranking)
void	updateAdvanceCorrections (float engineLoad)
floatms_t	getDwell () const
angle_t	getWrappedAdvance (const float rpm, const float engineLoad)
angle_t	getTrailingSparkAngle (const float rpm, const float engineLoad)
angle_t	getSparkHardwareLatencyCorrection ()

Static Public Member Functions
static angle_t	getInterpolatedIgnitionAngle (float rpm, float ignitionLoad)
static angle_t	getInterpolatedIgnitionTrim (size_t cylinderNumber, float rpm, float ignitionLoad)

Private Member Functions
angle_t	getAdvance (float rpm, float engineLoad)
floatms_t	getSparkDwell (float rpm, bool isCranking)

Additional Inherited Members
Data Fields inherited from ignition_state_s
float	baseDwell = (float)0
floatms_t	sparkDwell = (floatms_t)0
angle_t	dwellDurationAngle = (angle_t)0
scaled_channel< int16_t, 100, 1 >	cltTimingCorrection = (int16_t)0
scaled_channel< int16_t, 100, 1 >	timingIatCorrection = (int16_t)0
scaled_channel< int16_t, 100, 1 >	timingPidCorrection = (int16_t)0
scaled_channel< int16_t, 100, 1 >	dfcoTimingRetard = (int16_t)0
scaled_channel< int16_t, 50, 1 >	baseIgnitionAdvance = (int16_t)0
scaled_channel< int16_t, 50, 1 >	correctedIgnitionAdvance = (int16_t)0
scaled_channel< int16_t, 50, 1 >	tractionAdvanceDrop = (int16_t)0
uint8_t	alignmentFill_at_26 [2] = {}
float	dwellVoltageCorrection = (float)0
float	luaTimingAdd = (float)0
float	luaTimingMult = (float)0
bool	luaIgnitionSkip: 1 {}
bool	unusedBit_15_1: 1 {}
bool	unusedBit_15_2: 1 {}
bool	unusedBit_15_3: 1 {}
bool	unusedBit_15_4: 1 {}
bool	unusedBit_15_5: 1 {}
bool	unusedBit_15_6: 1 {}
bool	unusedBit_15_7: 1 {}
bool	unusedBit_15_8: 1 {}
bool	unusedBit_15_9: 1 {}
bool	unusedBit_15_10: 1 {}
bool	unusedBit_15_11: 1 {}
bool	unusedBit_15_12: 1 {}
bool	unusedBit_15_13: 1 {}
bool	unusedBit_15_14: 1 {}
bool	unusedBit_15_15: 1 {}
bool	unusedBit_15_16: 1 {}
bool	unusedBit_15_17: 1 {}
bool	unusedBit_15_18: 1 {}
bool	unusedBit_15_19: 1 {}
bool	unusedBit_15_20: 1 {}
bool	unusedBit_15_21: 1 {}
bool	unusedBit_15_22: 1 {}
bool	unusedBit_15_23: 1 {}
bool	unusedBit_15_24: 1 {}
bool	unusedBit_15_25: 1 {}
bool	unusedBit_15_26: 1 {}
bool	unusedBit_15_27: 1 {}
bool	unusedBit_15_28: 1 {}
bool	unusedBit_15_29: 1 {}
bool	unusedBit_15_30: 1 {}
bool	unusedBit_15_31: 1 {}
scaled_channel< int16_t, 100, 1 >	trailingSparkAngle = (int16_t)0
int16_t	rpmForIgnitionTableDot = (int16_t)0
int16_t	rpmForIgnitionIdleTableDot = (int16_t)0
uint8_t	alignmentFill_at_50 [2] = {}
float	loadForIgnitionTableDot = (float)0

Detailed Description

Definition at line 5 of file ignition_state.h.

Member Function Documentation

getAdvance()

angle_t IgnitionState::getAdvance ( float  rpm, float  engineLoad  )

private

Definition at line 211 of file ignition_state.cpp.

                                                             {
    if (std::isnan(engineLoad)) {
        return 0; // any error should already be reported
    }
  if (engineConfiguration->timingMode == TM_FIXED) {
        // fixed timing is the simple: cranking/running does not matter, no corrections!
        return engineConfiguration->fixedTiming;
    }
 
    angle_t angle;
 
    bool isCranking = engine->rpmCalculator.isCranking();
    if (isCranking) {
        angle = getCrankingAdvance(rpm, engineLoad);
        assertAngleRange(angle, "crAngle", ObdCode::CUSTOM_ERR_ANGLE_CR);
        efiAssert(ObdCode::CUSTOM_ERR_ASSERT, !std::isnan(angle), "cr_AngleN", 0);
    } else {
        angle = getRunningAdvance(rpm, engineLoad);
 
        if (std::isnan(angle)) {
            warning(ObdCode::CUSTOM_ERR_6610, "NaN angle from table");
            return 0;
        }
    }
 
    // Allow if we're either not cranking OR allowed to correct in cranking
    bool allowCorrections = !isCranking || engineConfiguration->useAdvanceCorrectionsForCranking;
 
    if (allowCorrections) {
        angle_t correction = getAdvanceCorrections(engineLoad);
        if (!std::isnan(correction)) { // correction could be NaN during settings update
            angle += correction;
        }
    }
 
    efiAssert(ObdCode::CUSTOM_ERR_ASSERT, !std::isnan(angle), "_AngleN5", 0);
    return angle;
}

Referenced by getWrappedAdvance().

Here is the call graph for this function:

Here is the caller graph for this function:

getDwell()

floatms_t IgnitionState::getDwell

(

)

const

Definition at line 342 of file ignition_state.cpp.

                                        {
    return sparkDwell;
}

Referenced by fireSparkAndPrepareNextSchedule(), getCoilDutyCycle(), initializeIgnitionActions(), onTriggerEventSparkLogic(), and updateDwell().

Here is the caller graph for this function:

getInterpolatedIgnitionAngle()

angle_t IgnitionState::getInterpolatedIgnitionAngle ( float  rpm, float  ignitionLoad  )

static

Definition at line 368 of file ignition_state.cpp.

                                                                                             {
    return interpolate3d(
        config->ignitionTable,
        config->ignitionLoadBins, ignitionLoad,
        config->ignitionRpmBins, rpm
    );
}

Referenced by getRunningAdvance().

Here is the call graph for this function:

Here is the caller graph for this function:

getInterpolatedIgnitionTrim()

angle_t IgnitionState::getInterpolatedIgnitionTrim ( size_t  cylinderNumber, float  rpm, float  ignitionLoad  )

static

Definition at line 376 of file ignition_state.cpp.

  {
    return interpolate3d(
        config->ignTrims[cylinderNumber].table,
        config->ignTrimLoadBins, ignitionLoad,
        config->ignTrimRpmBins, rpm
    );
}

Referenced by getCylinderIgnitionTrim().

Here is the call graph for this function:

Here is the caller graph for this function:

getSparkDwell()

floatms_t IgnitionState::getSparkDwell ( float  rpm, bool  isCranking  )

private

Returns

Spark dwell time, in milliseconds. 0 if tables are not ready.

Definition at line 307 of file ignition_state.cpp.

                                                                 {
    float dwellMs;
    if (isCranking) {
        dwellMs = engineConfiguration->ignitionDwellForCrankingMs;
    } else {
        efiAssert(ObdCode::CUSTOM_ERR_ASSERT, !std::isnan(rpm), "invalid rpm", NAN);
 
        baseDwell = interpolate2d(rpm, config->sparkDwellRpmBins, config->sparkDwellValues);
        dwellVoltageCorrection = interpolate2d(
                Sensor::getOrZero(SensorType::BatteryVoltage),
                config->dwellVoltageCorrVoltBins,
                config->dwellVoltageCorrValues
        );
 
        // for compat (table full of zeroes)
        if (dwellVoltageCorrection < 0.1f) {
            dwellVoltageCorrection = 1;
        }
 
        dwellMs = baseDwell * dwellVoltageCorrection;
    }
 
    if (std::isnan(dwellMs) || dwellMs <= 0) {
        // this could happen during engine configuration reset
        warning(ObdCode::CUSTOM_ERR_DWELL_DURATION, "invalid dwell: %.2f at rpm=%.0f", dwellMs, rpm);
        return 0;
    }
    return dwellMs;
}

Referenced by updateDwell().

Here is the call graph for this function:

Here is the caller graph for this function:

getSparkHardwareLatencyCorrection()

angle_t IgnitionState::getSparkHardwareLatencyCorrection

(

)

Definition at line 358 of file ignition_state.cpp.

                                                        {
    // time => degree
    angle_t correction = engineConfiguration->sparkHardwareLatencyCorrection / engine->rpmCalculator.oneDegreeUs;
 
    if (!std::isnan(correction)) {
        return correction;
    }
    return 0;
}

Referenced by EngineState::periodicFastCallback().

Here is the caller graph for this function:

getTrailingSparkAngle()

angle_t IgnitionState::getTrailingSparkAngle	(	const float	rpm,
		const float	engineLoad
	)

Definition at line 346 of file ignition_state.cpp.

                                                                                     {
    if (std::isnan(engineLoad)) {
        // default value from: https://github.com/rusefi/rusefi/commit/86683afca22ed1a8af8fd5ac9231442e2124646e#diff-6e80cdd8c55add68105618ad9e8954170a47f59814201dadd2b888509d6b2e39R176
        return 10;
    }
    return interpolate3d(
            config->trailingSparkTable,
            config->trailingSparkLoadBins, engineLoad,
            config->trailingSparkRpmBins, rpm
    );
}

Referenced by EngineState::periodicFastCallback().

Here is the caller graph for this function:

getWrappedAdvance()

angle_t IgnitionState::getWrappedAdvance	(	const float	rpm,
		const float	engineLoad
	)

Definition at line 250 of file ignition_state.cpp.

                                                                                {
    angle_t angle = getAdvance(rpm, engineLoad) * luaTimingMult + luaTimingAdd;
    wrapAngle(angle, "getWrappedAdvance", ObdCode::CUSTOM_ERR_ADCANCE_CALC_ANGLE);
    return angle;
}

Referenced by EngineState::periodicFastCallback().

Here is the call graph for this function:

Here is the caller graph for this function:

updateAdvanceCorrections()

void IgnitionState::updateAdvanceCorrections

(

float

engineLoad

)

Definition at line 160 of file ignition_state.cpp.

                                                             {
    cltTimingCorrection = getCltTimingCorrection(engineLoad);
}

Referenced by EngineState::periodicFastCallback().

Here is the call graph for this function:

Here is the caller graph for this function:

updateDwell()

void IgnitionState::updateDwell	(	float	rpm,
		bool	isCranking
	)

Definition at line 337 of file ignition_state.cpp.

                                                          {
    sparkDwell = getSparkDwell(rpm, isCranking);
    dwellDurationAngle = std::isnan(rpm) ? NAN : getDwell() / getOneDegreeTimeMs(rpm);
}

Referenced by EngineState::periodicFastCallback().

Here is the call graph for this function:

Here is the caller graph for this function:

---

The documentation for this class was generated from the following files:

• controllers/algo/ignition/ignition_state.h
• controllers/algo/ignition/ignition_state.cpp