default_base_engine.cpp

Go to the documentation of this file.

#include "pch.h"
 
#include "defaults.h"
#include "vr_pwm.h"
#include "kline.h"
#include "engine_configuration_defaults.h"
#include <rusefi/manifest.h>
#if HW_PROTEUS
#include "proteus_meta.h"
#endif // HW_PROTEUS
 
#if EFI_ALTERNATOR_CONTROL
static void setDefaultAlternatorParameters() {
    setTable(config->alternatorVoltageTargetTable, 14);
 
    engineConfiguration->alternatorControl.offset = 0;
    engineConfiguration->alternatorControl.pFactor = 30;
    engineConfiguration->alternatorControl.periodMs = 100;
}
#endif // EFI_ALTERNATOR_CONTROL
 
void setHpfpLobeProfileAngle(int lobes) {
#if HPFP_LOBE_PROFILE_SIZE == 16
static const float hardCodedHpfpLobeProfileAnglesForThreeLobes[16] = {0.0, 7.5, 16.5, 24.0,
32.0 , 40.0, 48.0, 56.0,
64.0 , 72.0, 80.0, 88.0,
96.0 , 103.5, 112.5, 120.0
};
 
  float multiplier = 3.0 / lobes;
    for (size_t i = 0; i < HPFP_LOBE_PROFILE_SIZE; i++) {
    config->hpfpLobeProfileAngle[i] = multiplier * hardCodedHpfpLobeProfileAnglesForThreeLobes[i];
    }
#endif // HPFP_LOBE_PROFILE_SIZE
}
 
static void setDefaultHPFP() {
#if ! EFI_UNIT_TEST
    // unit tests rely on 'hpfpCamLobes' for isGdiEngine() and we need not-GDI by default for unit tests
    engineConfiguration->hpfpCamLobes = 3;
#endif
 
// todo: would be nice for unit tests to be happy about these defaults
#if EFI_PROD_CODE || EFI_SIMULATOR
    engineConfiguration->hpfpPumpVolume = 0.290;
#endif
    engineConfiguration->hpfpMinAngle = 10;
    engineConfiguration->hpfpActivationAngle = 30;
    engineConfiguration->hpfpTargetDecay = 2000;
    engineConfiguration->hpfpPidP = 0.01;
    engineConfiguration->hpfpPidI = 0.0003;
    engineConfiguration->hpfpPeakPos = 10;
}
 
static void setGdiDefaults() {
  setDefaultHPFP();
 
    setRpmTableBin(config->hpfpTargetRpmBins);
    setLinearCurve(config->hpfpTargetLoadBins, 0, 180, 1);
    setTable(config->hpfpTarget, 5000);
 
    setLinearCurve(config->hpfpFuelMassCompensationFuelMass, 0.0, 500, 10);
    setLinearCurve(config->hpfpFuelMassCompensationFuelPressure, 0, 300, 25);
    setTable(config->hpfpFuelMassCompensation, 1.0);
 
    setLinearCurve(config->injectorFlowLinearizationFuelMassBins, 0.0, 500, 10);
    setLinearCurve(config->injectorFlowLinearizationPressureBins, 0, 300, 25);
}
 
void setGDIFueling() {
#ifdef HW_HELLEN_8CHAN
  engineConfiguration->externalRusEfiGdiModule = true;
#endif
 
    engineConfiguration->injectionMode = IM_SEQUENTIAL;
    engineConfiguration->crankingInjectionMode = IM_SEQUENTIAL;
    engineConfiguration->ignitionMode = IM_INDIVIDUAL_COILS;
 
  setGdiWallWetting();
    // Use high pressure sensor
    engineConfiguration->injectorPressureType = IPT_High;
    // Automatic compensation of injector flow based on rail pressure
    engineConfiguration->injectorCompensationMode = ICM_SensedRailPressure;
    // Reference rail pressure is 10 000 kPa = 100 bar
    engineConfiguration->fuelReferencePressure = 10000;
    //setting "flat" 0.2 ms injector's lag time
    setTable(engineConfiguration->injector.battLagCorrTable, 0.2);
 
    setTable(config->injectionPhase, -200.0f);
    engineConfiguration->injectionTimingMode = InjectionTimingMode::Center;
    engineConfiguration->isPhaseSyncRequiredForIgnition = true;
}
 
/* Cylinder to bank mapping */
void setLeftRightBanksNeedBetterName() {
    for (size_t i = 0; i < engineConfiguration->cylindersCount; i++) {
      // zero-based index
        engineConfiguration->cylinderBankSelect[i] = i % 2;
    }
}
 
static void mc33810defaults() {
  engineConfiguration->mc33810Nomi = 5.5;
  engineConfiguration->mc33810maxDwellTimer = mc33810maxDwellTimer_e::DWELL_8MS;
  engineConfiguration->mc33810Maxi = 14;
}
 
void setDynoDefaults() {
    config->dynoRpmStep = 100;
 
    config->dynoSaeTemperatureC = 20;
    config->dynoSaeBaro = STD_ATMOSPHERE;
    config->dynoSaeRelativeHumidity = 80;
 
    config->dynoCarWheelDiaInch = 18;
    config->dynoCarWheelTireWidthMm = 235;
    config->dynoCarWheelAspectRatio = 40;
 
    config->dynoCarGearPrimaryReduction = 1;
    config->dynoCarGearRatio = 1.0;
    config->dynoCarGearFinalDrive = 4.2;
 
    config->dynoCarCarMassKg = 1000;
    config->dynoCarCargoMassKg = 95;
    config->dynoCarCoeffOfDrag = 0.29;
    config->dynoCarFrontalAreaM2 = 1.85;
 }
 
void defaultsOrFixOnBurn() {
  if (config->dynoCarCarMassKg == 0) {
    setDynoDefaults();
  }
 
    if (engineConfiguration->mapExpAverageAlpha <= 0 || engineConfiguration->mapExpAverageAlpha > 1) {
      engineConfiguration->mapExpAverageAlpha = 1;
    }
 
    if (engineConfiguration->ppsExpAverageAlpha <= 0 || engineConfiguration->ppsExpAverageAlpha > 1) {
      engineConfiguration->ppsExpAverageAlpha = 1;
    }
    if (engineConfiguration->afrExpAverageAlpha <= 0 || engineConfiguration->afrExpAverageAlpha > 1) {
      engineConfiguration->afrExpAverageAlpha = 1;
    }
 
    if (engineConfiguration->referenceTorqueForGenerator == 0) {
    engineConfiguration->referenceTorqueForGenerator = 250;
    }
    if (engineConfiguration->referenceMapForGenerator == 0) {
    engineConfiguration->referenceMapForGenerator = 100;
    }
    if (engineConfiguration->referenceVeForGenerator == 0) {
    engineConfiguration->referenceVeForGenerator = 75;
    }
 
    if (engineConfiguration->alternator_iTermMin == 0) {
    engineConfiguration->alternator_iTermMin = -1000;
    }
    if (engineConfiguration->alternator_iTermMax == 0) {
    engineConfiguration->alternator_iTermMax = 1000;
    }
    if (engineConfiguration->idleReturnTargetRampDuration <= 0.1){
        engineConfiguration->idleReturnTargetRampDuration = 3;
    }
 
    if (engineConfiguration->vvtControlMinRpm < engineConfiguration->cranking.rpm) {
        engineConfiguration->vvtControlMinRpm = engineConfiguration->cranking.rpm;
    }
}
 
void setDefaultBaseEngine() {
    // Base Engine Settings
    engineConfiguration->displacement = 2;
    engineConfiguration->knockDetectionUseDoubleFrequency = true;
#if MAX_CYLINDER_COUNT >= 4
    setInline4();
#else
  // todo: invoke more complete one cylinder default?
  engineConfiguration->cylindersCount = 1;
#endif
 
  engineConfiguration->isTuningDetectorEnabled = true;
 
  for (size_t i = 0; i < engineConfiguration->cylindersCount; i++) {
    // one knock sensor by default. See also 'setLeftRightBanksNeedBetterName()'
    // zero-based index
    engineConfiguration->cylinderBankSelect[i] = 0;
  }
 
  engineConfiguration->ltft.enabled = true;
  engineConfiguration->ltft.correctionEnabled = true;
 
    engineConfiguration->compressionRatio = 9;
    engineConfiguration->vssFilterReciprocal = VSS_FILTER_MIN;
    engineConfiguration->boardUseCanTerminator = true;
    engineConfiguration->acLowRpmLimit = 500;
 
    engineConfiguration->mafFilterParameter = 1;
 
#ifdef EFI_KLINE
  engineConfiguration->kLinePeriodUs = 300 /* us*/;
  engineConfiguration->kLineDoHondaSend = true;
#endif
 
  setGdiDefaults();
 
  // it's useful to know what starting point is given tune based on
  engineConfiguration->calibrationBirthday = compilationYear() * 10000 + compilationMonth() * 100 + compilationDay();
 
  engineConfiguration->enableExtendedCanBroadcast = true;
 
  engineConfiguration->fan1ExtraIdle = 2;
  engineConfiguration->fan2ExtraIdle = 2;
 
  engineConfiguration->auxSpeed1Multiplier = 1;
  engineConfiguration->magicNumberAvailableForDevTricks = 1;
 
  engineConfiguration->acrRevolutions = 5;
    engineConfiguration->acPressure.v2 = 5;
    engineConfiguration->acPressure.value2 = 100;
 
    engineConfiguration->lowPressureFuel.v2 = 5;
    engineConfiguration->lowPressureFuel.value2 = 100;
 
    engineConfiguration->wastegatePositionOpenedVoltage = 4.0;
 
  engineConfiguration->fuelLevelAveragingAlpha = engine_configuration_defaults::FUEL_LEVEL_AVERAGING_ALPHA;
  engineConfiguration->fuelLevelUpdatePeriodSec = engine_configuration_defaults::FUEL_LEVEL_UPDATE_PERIOD_SEC;
  engineConfiguration->fuelLevelLowThresholdVoltage = engine_configuration_defaults::FUEL_LEVEL_LOW_THRESHOLD_VOLTAGE;
  engineConfiguration->fuelLevelHighThresholdVoltage = engine_configuration_defaults::FUEL_LEVEL_HIGH_THRESHOLD_VOLTAGE;
 
  engineConfiguration->watchOutForLinearTime = true;
 
  setLinearCurve(engineConfiguration->tractionControlSlipBins, /*from*/0.9, /*to*/1.2, 0.05);
    setLinearCurve(engineConfiguration->tractionControlSpeedBins, /*from*/10, /*to*/120, 5);
 
    engineConfiguration->turbochargerFilter = 0.01f;
 
    mc33810defaults();
 
    setRpmTableBin(config->torqueRpmBins);
    // here we assume load is TPS
    setLinearCurve(config->torqueLoadBins, 0, 100, 1);
 
    engineConfiguration->fuelAlgorithm = engine_load_mode_e::LM_SPEED_DENSITY;
    // let's have valid default while we still have the field
    engineConfiguration->debugMode = DBG_EXECUTOR;
 
  engineConfiguration->speedometerPulsePerKm = 2485; // GM GMT800 platform
 
    engineConfiguration->primingDelay = 0.5;
    // this should not be below default rpm! maybe even make them equal?
    engineConfiguration->vvtControlMinRpm = 600;
 
  // todo: this "2JZ" trigger is very powerful for many low tooth quantity applications
  // todo: we might be getting closer to a re-name
  // by the way 2GRFE intake likes position 160 / precision 20
  // see also https://github.com/rusefi/rusefi/issues/7345
  //
  // 2JZ values
    engineConfiguration->camDecoder2jzPosition = 95;
    engineConfiguration->camDecoder2jzPrecision = 40;
 
    // Limits and Fallbacks
    engineConfiguration->rpmHardLimit = 7000;
    engineConfiguration->rpmHardLimitHyst = 50;
    engineConfiguration->cutFuelOnHardLimit = true;
    engineConfiguration->cutSparkOnHardLimit = true;
    engineConfiguration->etbRevLimitRange = 250;
 
  engineConfiguration->tpsAccelFractionDivisor = 1;
 
  engineConfiguration->rpmSoftLimitTimingRetard = 4;
 
    // CLT RPM limit table - just the X axis
    copyArray(config->cltRevLimitRpmBins, { -20, 0, 40, 80 });
 
    engineConfiguration->ALSMinRPM = 400;
    engineConfiguration->ALSMaxRPM = 3200;
    engineConfiguration->ALSMaxDuration = 3;
    engineConfiguration->ALSMaxCLT = 105;
//  engineConfiguration->alsMinPps = 10;
    engineConfiguration->alsMinTimeBetween = 5;
    engineConfiguration->alsEtbPosition = 30;
    engineConfiguration->ALSMaxTPS = 5;
 
    engineConfiguration->torqueReductionActivationTemperature = 60;
 
    engineConfiguration->knockRetardAggression = 20;
    engineConfiguration->knockRetardReapplyRate = 3;
    engineConfiguration->knockFuelTrim = 0;
    engineConfiguration->knockSuppressMinTps = 10;
 
  setRpmTableBin(config->maxKnockRetardRpmBins);
  setLinearCurve(config->maxKnockRetardLoadBins, 0, 100, 1);
  setTable(config->maxKnockRetardTable, 20);
 
    // Trigger
    engineConfiguration->trigger.type = trigger_type_e::TT_TOOTHED_WHEEL_60_2;
 
#if EFI_SIMULATOR
    engineConfiguration->vvtMode[0] = VVT_SINGLE_TOOTH;
    engineConfiguration->vvtOffsets[0] = 450;
    engineConfiguration->vvtPins[0] = Gpio::A0; // a random unused pin needed to unblock startSimplePwmExt()
#endif // EFI_SIMULATOR
 
#if EFI_SIMULATOR
    // R
    config->tcuSolenoidTable[0][0] = 99;
    config->tcuSolenoidTable[0][1] = 1;
    config->tcuSolenoidTable[0][2] = 2;
    config->tcuSolenoidTable[0][3] = 3;
    config->tcuSolenoidTable[0][4] = 4;
    config->tcuSolenoidTable[0][5] = 5;
    // P/N
    config->tcuSolenoidTable[1][0] = 10;
    config->tcuSolenoidTable[1][1] = 11;
    config->tcuSolenoidTable[1][2] = 12;
    config->tcuSolenoidTable[1][3] = 13;
    config->tcuSolenoidTable[1][4] = 14;
    config->tcuSolenoidTable[1][5] = 15;
    config->tcuSolenoidTable[1][6] = 16;
    config->tcuSolenoidTable[1][7] = 17;
    config->tcuSolenoidTable[1][8] = 18;
    config->tcuSolenoidTable[1][9] = 19;
    // 1
    config->tcuSolenoidTable[2][0] = 20;
    config->tcuSolenoidTable[2][1] = 21;
    config->tcuSolenoidTable[2][2] = 22;
    // 2
    config->tcuSolenoidTable[3][0] = 30;
    config->tcuSolenoidTable[3][1] = 31;
    config->tcuSolenoidTable[3][3] = 33;
    // 3
    config->tcuSolenoidTable[4][0] = 40;
    config->tcuSolenoidTable[4][1] = 41;
    config->tcuSolenoidTable[4][4] = 44;
    // 4
    config->tcuSolenoidTable[5][0] = 50;
    config->tcuSolenoidTable[5][1] = 51;
    config->tcuSolenoidTable[5][5] = 55;
 
  // [tag:runNotSquareTest] huh why is this not a unit test?!
    config->scriptTable4[0][0] = 140;
    config->scriptTable4[0][1] = 141;
    config->scriptTable4[0][2] = 142;
    config->scriptTable4[0][3] = 143;
    config->scriptTable4[0][4] = 144;
    config->scriptTable4[0][5] = 145;
 
    config->scriptTable4[1][0] = 240;
    config->scriptTable4[1][1] = 241;
    config->scriptTable4[1][2] = 242;
    config->scriptTable4[1][3] = 243;
    config->scriptTable4[1][4] = 244;
    config->scriptTable4[1][5] = 245;
 
    config->scriptTable4[4][0] = 40;
    config->scriptTable4[4][2] = 41;
    config->scriptTable4[4][3] = 42;
    config->scriptTable4[4][4] = 43;
    config->scriptTable4[4][5] = 44;
    config->scriptTable4[4][5] = 45;
 
    config->scriptTable4[5][0] = 50;
    config->scriptTable4[5][1] = 51;
    config->scriptTable4[5][2] = 52;
    config->scriptTable4[5][3] = 53;
    config->scriptTable4[5][4] = 54;
    config->scriptTable4[5][5] = 55;
 
#endif // EFI_SIMULATOR
 
    engineConfiguration->globalTriggerAngleOffset = 0;
 
    // Default this to on - if you want to diagnose, turn it off.
    engineConfiguration->silentTriggerError = true;
 
    engineConfiguration->idleStepperReactionTime = 3;
    engineConfiguration->idleStepperTotalSteps = 200;
    engineConfiguration->stepperForceParkingEveryRestart = true;
    engineConfiguration->iacByTpsTaper = 2;
 
    engineConfiguration->etbSplit = MAX_TPS_PPS_DISCREPANCY;
 
    // Advanced Trigger
 
    // Battery and alternator
    engineConfiguration->vbattDividerCoeff = ((float) (15 + 65)) / 15;
 
#if EFI_ALTERNATOR_CONTROL
    setDefaultAlternatorParameters();
#endif /* EFI_ALTERNATOR_CONTROL */
 
    // Fuel pump
    // todo: maybe change to 2s as default?
    engineConfiguration->startUpFuelPumpDuration = 4;
 
    engineConfiguration->kLineBaudRate = KLINE_BAUD_RATE;
 
    engineConfiguration->benchTestOnTime = 4;
    engineConfiguration->benchTestOffTime = 500;
    engineConfiguration->benchTestCount = 3;
 
 
    // Tachometer
    // 50% duty cycle is the default for tach signal
    engineConfiguration->tachPulseDurationAsDutyCycle = true;
    engineConfiguration->tachPulseDuractionMs = 0.5;
    engineConfiguration->tachPulsePerRev = 1;
 
    engineConfiguration->etbMinimumPosition = 1;
    engineConfiguration->etbMaximumPosition = 100;
 
    engineConfiguration->tcuInputSpeedSensorTeeth = 1;
    engineConfiguration->issFilterReciprocal = 2;
 
    //knock
#ifdef KNOCK_SPECTROGRAM
    engineConfiguration->enableKnockSpectrogram = false;
    engineConfiguration->enableKnockSpectrogramFilter = false;
    engineConfiguration->knockSpectrumSensitivity = 1.0;
    engineConfiguration->knockFrequency = 0.0;
#endif
 
    // Check engine light
#if EFI_PROD_CODE
    engineConfiguration->warningPeriod = 10;
#else
    engineConfiguration->warningPeriod = 0;
#endif /* EFI_PROD_CODE */
 
    setDefaultVrThresholds();
 
    // Oil pressure protection
    engineConfiguration->minimumOilPressureTimeout = 0.5f;
    setRpmTableBin(config->minimumOilPressureBins);
    setRpmTableBin(config->maximumOilPressureBins);
 
    engine->engineModules.apply_all([](auto & m) { m.setDefaultConfiguration(); });
 
    engineConfiguration->useMetricOnInterface = true;
 
  // we invoke this last so that we can validate even defaults
  defaultsOrFixOnBurn();
}
 
void setPPSInputs(adc_channel_e pps1, adc_channel_e pps2) {
    engineConfiguration->throttlePedalPositionAdcChannel = pps1;
    engineConfiguration->throttlePedalPositionSecondAdcChannel = pps2;
}
 
void setTPS1Inputs(adc_channel_e tps1, adc_channel_e tps2) {
    engineConfiguration->tps1_1AdcChannel = tps1;
    engineConfiguration->tps1_2AdcChannel = tps2;
}
 
void setTPS1Calibration(uint16_t tpsMin, uint16_t tpsMax) {
    engineConfiguration->tpsMin = tpsMin;
    engineConfiguration->tpsMax = tpsMax;
}
 
void setTPS1Calibration(uint16_t tpsMin, uint16_t tpsMax, uint16_t tps1SecondaryMin, uint16_t tps1SecondaryMax) {
    setTPS1Calibration(tpsMin, tpsMax);
 
 
    engineConfiguration->tps1SecondaryMin = tps1SecondaryMin;
    engineConfiguration->tps1SecondaryMax = tps1SecondaryMax;
}
 
void setCustomMap(float lowValue, float mapLowValueVoltage, float highValue, float mapHighValueVoltage) {
    engineConfiguration->map.sensor.type = MT_CUSTOM;
    engineConfiguration->map.sensor.lowValue = lowValue;
    engineConfiguration->mapLowValueVoltage = mapLowValueVoltage;
    engineConfiguration->map.sensor.highValue = highValue;
    engineConfiguration->mapHighValueVoltage = mapHighValueVoltage;
}
 
void setPPSCalibration(float primaryUp, float primaryDown, float secondaryUp, float secondaryDown) {
    engineConfiguration->throttlePedalUpVoltage = primaryUp;
    engineConfiguration->throttlePedalWOTVoltage = primaryDown;
    engineConfiguration->throttlePedalSecondaryUpVoltage = secondaryUp;
    engineConfiguration->throttlePedalSecondaryWOTVoltage = secondaryDown;
}
 
void setEtbPID(float p, float i, float d) {
    engineConfiguration->etb.pFactor = p;
    engineConfiguration->etb.iFactor = i;
    engineConfiguration->etb.dFactor = d;
}
 
void setInline4() {
    engineConfiguration->cylindersCount = 4;
    engineConfiguration->firingOrder = FO_1_3_4_2;
}
 
void setProteusEtbIO() {
#if HW_PROTEUS && EFI_PROD_CODE
    engineConfiguration->tps1_2AdcChannel = PROTEUS_IN_TPS1_2;
    setPPSInputs(PROTEUS_IN_PPS, PROTEUS_IN_PPS2);
#endif // HW_PROTEUS
}
 
void setupTLE9201(Gpio controlPin, Gpio direction, Gpio disable, int dcIndex) {
    // TLE9201 driver
    // This chip has three control pins:
    // DIR - sets direction of the motor
    // PWM - pwm control (enable high, coast low)
    // DIS - disables motor (enable low)
 
    // PWM pin
    engineConfiguration->etbIo[dcIndex].controlPin = controlPin;
    // DIR pin
    engineConfiguration->etbIo[dcIndex].directionPin1 = direction;
    // Disable pin
    engineConfiguration->etbIo[dcIndex].disablePin = disable;
 
    // we only have pwm/dir, no dira/dirb
    engineConfiguration->etb_use_two_wires = false;
}
 
void setupTLE9201IncludingStepper(Gpio controlPin, Gpio direction, Gpio disable, int dcIndex) {
  setupTLE9201(controlPin, direction, disable, dcIndex);
 
  // on SBC style stepper IAC fully-extended valve shaft would give least idle air
  // fully-retracted valve shaft would give most idle air
  int stepperIndexWeirdness = 1 - dcIndex;
    engineConfiguration->stepperDcIo[stepperIndexWeirdness].controlPin = controlPin;
    engineConfiguration->stepperDcIo[stepperIndexWeirdness].directionPin1 = direction;
    engineConfiguration->stepperDcIo[stepperIndexWeirdness].directionPin2 = Gpio::Unassigned;
    engineConfiguration->stepperDcIo[stepperIndexWeirdness].disablePin = disable;
}